GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36127: Fix _PyArg_UnpackKeywords() warning by vstinner · Pull Request #12345 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 15, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use Py_ssize_t type rather than int for the 'i' variable.

https://bugs.python.org/issue36127

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-36127: Fix _PyArg_UnpackKeywords() warning
8f0d256 
Use Py_ssize_t type rather than int for the 'i' variable.
@vstinner
vstinner requested a review from serhiy-storchaka March 15, 2019 14:03
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 15, 2019
@bedevere-bot bedevere-bot added the awaiting merge label Mar 15, 2019
@vstinner vstinner added skip news and removed awaiting merge labels Mar 15, 2019
@vstinner

vstinner commented Mar 15, 2019

Copy link
Copy Markdown
Member Author

This change fix the following warning on Windows:

c:\projects\cpython\python\getargs.c(2425): warning C4244: '=': conversion from 'Py_ssize_t' to 'int', possible loss of data [C:\projects\cpython\PCbuild\pythoncore.vcxproj]

@serhiy-storchaka: Would you mind to review this change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Mar 15, 2019

Copy link
Copy Markdown
Member

I do not think this is the best way to fix this warning. All corresponding variables except nargs have type int, and I want to preserve this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 15, 2019

Copy link
Copy Markdown
Member Author

I do not think this is the best way to fix this warning. All corresponding variables except nargs have type int, and I want to preserve this.

Why is it wrong to use Py_ssize_t for 'i'?

I don't want to use Py_ssize_t for other variables, since _PyParser uses int.

Feel free to fix the warning differently. I only worry of having no compiler warning on Windows :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

Serhiy wrote a diffrent fix: PR #12353.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Mar 18, 2019
@vstinner
vstinner deleted the getargs_warn branch March 18, 2019 17:39
loic-simon added a commit to loic-simon/cpython that referenced this pull request Apr 30, 2025
@loic-simon
pythongh-12345: Improve documentation of http.HTTPStatus members update
6a5d35a
gpshead added a commit to gpshead/blurb that referenced this pull request Jul 4, 2025
@gpshead @picnixz
Add user-friendly interface improvements to blurb add command
2106ae6 
Integrate the user-friendly features from PR python#16 by @picnixz into the
automation support from PR python#45, making the CLI more intuitive:

- Change --gh-issue to --issue, accepting multiple formats:
  * Plain numbers: --issue 12345
  * With gh- prefix: --issue gh-12345
  * GitHub URLs: --issue python/cpython#12345

- Add smart section matching with:
  * Case-insensitive matching: --section lib matches "Library"
  * Partial matching: --section doc matches "Documentation"
  * Common aliases: --section api matches "C API"
  * Separator normalization: --section core-and-builtins

- Improve error messages for invalid sections

This combines the automation features from PR python#45 with the interface
improvements suggested by @picnixz in PR python#16, as reviewed by @hugovk
and @larryhastings.

Co-authored-by: picnixz <[email protected]>
@gpshead gpshead mentioned this pull request Jul 4, 2025
Add user-friendly interface improvements to blurb add command gpshead/blurb#1
Merged
gpshead added a commit to gpshead/blurb that referenced this pull request Jul 4, 2025
@gpshead
Integrate the user-friendly features from PR python#16 by @picnixz
8217638 
Integrate the user-friendly features from PR python#16 by @picnixz into the automation support from PR python#45, making the CLI more intuitive:

- Change --gh-issue to --issue, accepting multiple formats:
  * Plain numbers: --issue 12345
  * With gh- prefix: --issue gh-12345
  * GitHub URLs: --issue python/cpython#12345

- Add smart section matching with:
  * Case-insensitive matching: --section lib matches "Library"
  * Partial matching: --section doc matches "Documentation"
  * Common aliases: --section api matches "C API"
  * Separator normalization: --section core-and-builtins

- Improve error messages for invalid sections

This combines the automation features from PR python#45 with the interface improvements suggested by @picnixz in PR python#16, as reviewed by @hugovk and @larryhastings.
@hugovk hugovk mentioned this pull request Sep 8, 2025
gh-101100: Resolve reference warnings in reference/ #138418
Merged
@b9788213 b9788213 mentioned this pull request Jan 15, 2026
gh-143866: Verify return value of pathlib write methods in tests #143870
Merged
@pgoslatara pgoslatara mentioned this pull request Jan 21, 2026
chore: Update outdated GitHub Actions versions #144103
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.