GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-93691: fix too broad source locations of with-statement instructions (GH-120125) by miss-islington · Pull Request #123604 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 2, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit eca3f77)

Co-authored-by: Irit Katriel [email protected]

  • Issue: Bytecode positions seem way too broad #93691

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel @miss-islington
pythongh-93691: fix too broad source locations of with-statement inst…
0da05d4 
…ructions (pythonGH-120125)

(cherry picked from commit eca3f77)

Co-authored-by: Irit Katriel <[email protected]>
@miss-islington
miss-islington requested review from iritkatriel and markshannon as code owners September 2, 2024 14:28
@bedevere-app bedevere-app Bot added the awaiting review label Sep 2, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 2, 2024
gh-93691: fix too broad source locations of with-statement instructions #120125
Merged
@bedevere-app bedevere-app Bot added the type-bug An unexpected behavior, bug, or error label Sep 2, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 2, 2024
Bytecode positions seem way too broad #93691
Closed
iritkatriel
iritkatriel approved these changes Sep 2, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 2, 2024
@iritkatriel
iritkatriel enabled auto-merge (squash) September 2, 2024 14:30
@iritkatriel
iritkatriel merged commit 494181e into python:3.13 Sep 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 2, 2024
@miss-islington
miss-islington deleted the backport-eca3f77-3.13 branch January 2, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.