GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93691: fix too broad source locations of with-statement instructions by iritkatriel · Pull Request #120125 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jun 5, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Previously an exception from the __init__, __enter__ and __exit__ would give the whole with-statement, with the body, as the location. Now it pinpoints which context manager failed.

  • Issue: Bytecode positions seem way too broad #93691

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-93691: fix too broad source locations of with-statement inst…
5a91e79 
…ructions
@iritkatriel
iritkatriel requested a review from markshannon as a code owner June 5, 2024 17:27
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 5, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 5, 2024
Bytecode positions seem way too broad #93691
Closed
iritkatriel and others added 2 commits June 5, 2024 18:29
@iritkatriel
add news
8936ea0
@iritkatriel
Merge branch 'main' into with_location
5b9c586
carljm
carljm approved these changes Jun 6, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 6, 2024
@iritkatriel
iritkatriel merged commit eca3f77 into python:main Jun 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 7, 2024
@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label Jun 10, 2024
@dmadisetti dmadisetti mentioned this pull request Jul 17, 2024
White space causes inconsistent frame traversal in With blocks #121865
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel @estyxx
pythongh-93691: fix too broad source locations of with-statement inst…
e9cefff 
…ructions (python#120125)
@iritkatriel iritkatriel added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 2, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 2, 2024

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Sep 2, 2024

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @miss-islington
pythongh-93691: fix too broad source locations of with-statement inst…
0da05d4 
…ructions (pythonGH-120125)

(cherry picked from commit eca3f77)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 2, 2024

Copy link
Copy Markdown

GH-123604 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 2, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @miss-islington
pythongh-93691: fix too broad source locations of with-statement inst…
35f1856 
…ructions (pythonGH-120125)

(cherry picked from commit eca3f77)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 2, 2024

Copy link
Copy Markdown

GH-123605 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 2, 2024
@iritkatriel iritkatriel mentioned this pull request Sep 2, 2024
[3.13] gh-98442: fix locations of with statement's cleanup instructions (GH-120763) #120786
Merged
iritkatriel added a commit that referenced this pull request Sep 2, 2024
@miss-islington @iritkatriel
[3.12] gh-93691: fix too broad source locations of with-statement ins…
22ec9cb 
…tructions (GH-120125) (#123605)

gh-93691: fix too broad source locations of with-statement instructions (GH-120125)
(cherry picked from commit eca3f77)

Co-authored-by: Irit Katriel <[email protected]>
iritkatriel added a commit that referenced this pull request Sep 2, 2024
@miss-islington @iritkatriel
[3.13] gh-93691: fix too broad source locations of with-statement ins…
494181e 
…tructions (GH-120125) (#123604)

gh-93691: fix too broad source locations of with-statement instructions (GH-120125)
(cherry picked from commit eca3f77)

Co-authored-by: Irit Katriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.