GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108219: Add credits to free-threading project by corona10 · Pull Request #123802 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Sep 7, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PEP 703 -- Making the Global Interpreter Lock Optional in CPython #108219

📚 Documentation preview 📚: https://cpython-previews--123802.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
argon-kr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@corona10
pythongh-108219: Add credits to free-threading project
8dade83
@corona10
corona10 requested review from Yhg1s, colesbury and hugovk September 7, 2024 02:06
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 7, 2024
@corona10 corona10 added skip news and removed awaiting core review labels Sep 7, 2024
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Sep 7, 2024
@corona10 corona10 added needs backport to 3.13 only security fixes and removed docs Documentation in the Doc dir labels Sep 7, 2024
corona10 added 2 commits September 7, 2024 11:19
@corona10
nit
c577402
@corona10
fix
fe2f028
willingc
willingc reviewed Sep 7, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated
free-threaded build.

This project has been contributed by many people and the community,
including Brett Simmers, Dino Viehland, Donghee Na, Ken Jin, Matt Page, and Sam Gross.

@willingc willingc Sep 7, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include @iritkatriel and a few others from Microsoft too?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iritkatriel iritkatriel Sep 7, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
willingc reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@corona10 corona10 Sep 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if I miss someone at Microsoft team.
cc @Fidget-Spinner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@itamaro itamaro Sep 8, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, I think there are too many contributors to try listing them exhaustively. Maybe go with something like "Sam Gross and many others"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@corona10 corona10 Sep 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: As the person listed in the description, I am biased, so I have no opinions about it.

But listing people as possible can give motivation to work projects not only for this but also other projects. For the faster-cpython project, they listed as many people as possible, so it was a great honor for me, and it motivated me to participate in other projects.
(And It can also be a good reference for persuading a company to let people work part-time on the CPython project.)

"Sam Gross and many others"?

I think this is the minimum option that should be used if there is controversy regarding this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itamaro and darjeeling reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@corona10 corona10 Sep 8, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I also think there should be more people on the list. Please let me know or have the person update the description with more details.
(I just picked people with free-threading labels)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
darjeeling reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@Fidget-Spinner Fidget-Spinner Sep 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the MS team because I'm also not employed by them :) but IMO/IIUC the MS team is focused on single-threaded JIT performance mostly. So they werent much involved in the 3.13 free threaded effort, apart from discussions and design help we received from them, which I'm thankful for.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 and willingc reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@corona10
Itamar Oren should be listed for the infrastructure
c45cdfb
AA-Turner
AA-Turner reviewed Sep 8, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated
Comment on lines +357 to +360
This project has been contributed by many people and the community,
including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin,
Matt Page, and Sam Gross.
Meta has supported in the form of many engineer-years to this project.

@AA-Turner AA-Turner Sep 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording suggestions (on mobile so I can't easily check line wrapping)

Suggested change
This project has been contributed by many people and the community,
including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin,
Matt Page, and Sam Gross.
Meta has supported in the form of many engineer-years to this project.
This work is thanks to many people and organisations, including the large community of contributors
to Python and third party projects to test and enable free-threading support.
This includes, but is not limited to:
Sam Gross, Ken Jin, Donghee Na, Itamar Oren, Matt Page, Brett Simmers, and Dino Viehland.
Many of these contributors are employed by Meta Inc,
which has provided significant manpower to support this project.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 and willingc reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@corona10 corona10 Sep 8, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's more better, and @itamaro is going to add more detail by next week :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10 @AA-Turner
Update Doc/whatsnew/3.13.rst
9929867 
Co-authored-by: Adam Turner <[email protected]>
AA-Turner
AA-Turner approved these changes Sep 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Sep 8, 2024
hugovk
hugovk reviewed Sep 8, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 and others added 2 commits September 8, 2024 19:03
@corona10 @hugovk
Apply suggestions from code review
d900780 
Co-authored-by: Hugo van Kemenade <[email protected]>
@corona10
Use a gender-neutral term
33be59e
itamaro
itamaro reviewed Sep 8, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10 @itamaro
Update Doc/whatsnew/3.13.rst
79ec285 
Co-authored-by: Itamar Oren <[email protected]>
@corona10
corona10 requested review from AA-Turner, hugovk and itamaro September 8, 2024 17:02
itamaro
itamaro approved these changes Sep 8, 2024
View reviewed changes
willingc
willingc approved these changes Sep 8, 2024
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 Thanks for making the effort to be inclusive with the credits after my initial comment. Looks good to me now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
AA-Turner
AA-Turner approved these changes Sep 8, 2024
View reviewed changes
@AA-Turner
AA-Turner merged commit aa3f11f into python:main Sep 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 8, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 8, 2024

Copy link
Copy Markdown

Thanks @corona10 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2024
@corona10 @AA-Turner
@hugovk @itamaro @miss-islington
pythongh-108219: Add credits to the free-threading entry in What's New (
f368d39 
pythonGH-123802)

(cherry picked from commit aa3f11f)

Co-authored-by: Donghee Na <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Itamar Oren <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 8, 2024

Copy link
Copy Markdown

GH-123847 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 8, 2024
@corona10
corona10 deleted the gh-108219-authors branch September 9, 2024 01:07
Yhg1s pushed a commit that referenced this pull request Sep 24, 2024
@miss-islington @corona10
@AA-Turner @hugovk @itamaro
[3.13] gh-108219: Add credits to the free-threading entry in What's N…
87f51a2 
…ew (GH-123802) (#123847)

gh-108219: Add credits to the free-threading entry in What's New (GH-123802)
(cherry picked from commit aa3f11f)

Co-authored-by: Donghee Na <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Itamar Oren <[email protected]>
@kumaraditya303 kumaraditya303 mentioned this pull request Nov 16, 2024
PEP 703 -- Making the Global Interpreter Lock Optional in CPython #108219
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments
@itamaro itamaro itamaro approved these changes
@willingc willingc willingc approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@colesbury colesbury Awaiting requested review from colesbury
@Yhg1s Yhg1s Awaiting requested review from Yhg1s
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@corona10 @itamaro @iritkatriel @hugovk @willingc @AA-Turner @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.