GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-123853: Corrected Cambodian language locale identifier by rruuaanng · Pull Request #123855 · python/cpython

Conversation

@rruuaanng

@rruuaanng rruuaanng commented Sep 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixed the locale identifier for Khmer, According to the info on https://ss64.com/locale.html, I changed it from kh_KH to km_KH.

  • Issue: locale.windows_locale: Incorrect Windows locale for Cambodian #123853

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rruuaanng
pythongh-123853: Corrected Cambodian language locale identifier
164ac6c
@bedevere-app bedevere-app Bot added the awaiting review label Sep 9, 2024
@bedevere-app

bedevere-app Bot commented Sep 9, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Sep 9, 2024
locale.windows_locale: Incorrect Windows locale for Cambodian #123853
Closed
rruuaanng added 2 commits September 9, 2024 15:34
@rruuaanng
Add NEWS
52c9ce1
@rruuaanng
change NEWS
438b1e4
@rruuaanng
rruuaanng force-pushed the dev3 branch from 4b756b3 to 438b1e4 Compare September 9, 2024 07:39
@seanbudd

seanbudd commented Sep 9, 2024

Copy link
Copy Markdown

I think it might be best to wait until #123855 is confirmed as an issue. I'm concerned of the impacts of changing this without a thorough discussion.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rruuaanng

rruuaanng commented Sep 9, 2024

Copy link
Copy Markdown
Contributor Author

I think it might be best to wait until #123855 is confirmed as an issue. I'm concerned of the impacts of changing this without a thorough discussion.

This PR won't be merged easily. If this isn't confirmed as an issue, I'll close the PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rruuaanng
Add space
b2b7a2e
@rruuaanng
rruuaanng force-pushed the dev3 branch from 829f7da to b2b7a2e Compare September 9, 2024 07:47
rruuaanng added 4 commits September 9, 2024 15:52
@rruuaanng
Removed the quotes
a8d473c
@rruuaanng
Trailing whitespace removed
02a18c6
@rruuaanng
Change to double backticks
17579c3
@rruuaanng
Merge branch 'main' into dev3
3c91cb9
@rruuaanng rruuaanng closed this Sep 9, 2024
@rruuaanng
rruuaanng deleted the dev3 branch September 9, 2024 08:29
@rruuaanng
rruuaanng restored the dev3 branch September 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rruuaanng @seanbudd
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.