GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-121735: Fix module-adjacent references in zip files (GH-123037) by miss-islington · Pull Request #123986 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

  • Un-deprecate functional API for importlib resources & add subdirectory support #116608: Apply style and compatibility changes from importlib_metadata.

  • Can't open orphan path on bare importlib.resources.files() under zipapp #121735: Ensure module-adjacent resources are loadable from a zipfile.

  • Can't open orphan path on bare importlib.resources.files() under zipapp #121735: Allow all modules to be processed by the ZipReader.

  • Add blurb

  • Remove update-zips script, unneeded.

  • Remove unnecessary references to removed static fixtures.

  • Remove zipdata fixtures, unused.
    (cherry picked from commit ba687d9)

Co-authored-by: Jason R. Coombs [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco @miss-islington
pythongh-121735: Fix module-adjacent references in zip files (pythonG…
6ec873e 
…H-123037)

* pythongh-116608: Apply style and compatibility changes from importlib_metadata.

* pythongh-121735: Ensure module-adjacent resources are loadable from a zipfile.

* pythongh-121735: Allow all modules to be processed by the ZipReader.

* Add blurb

* Remove update-zips script, unneeded.

* Remove unnecessary references to removed static fixtures.

* Remove zipdata fixtures, unused.
(cherry picked from commit ba687d9)

Co-authored-by: Jason R. Coombs <[email protected]>
@miss-islington
miss-islington requested review from FFY00, brettcannon, ericsnowcurrently, jaraco, ncoghlan and warsaw as code owners September 12, 2024 02:33
@bedevere-app bedevere-app Bot added the awaiting review label Sep 12, 2024
This was referenced Sep 12, 2024
gh-121735: Fix module-adjacent references in zip files #123037
Merged
Can't open orphan path on bare importlib.resources.files() under zipapp #121735
Closed
@jaraco
pythongh-123994: Generate utf-16 file using little endian and BOM. (p…
92f9a53 
…ython#123995)
@jaraco

jaraco commented Sep 12, 2024

Copy link
Copy Markdown
Member

Note that I cherry-picked #123995 to address build bot failures introduced by the original change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 12, 2024
gh-123085: Fix issue in inferred caller when resources package has no source #123102
Merged
[3.13] gh-123085: Fix issue in inferred caller when resource package has no source (GH-123102) #124024
Merged
@brettcannon
brettcannon removed their request for review September 13, 2024 18:47
@Yhg1s
Yhg1s merged commit 40b27d0 into python:3.13 Sep 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 30, 2024
@miss-islington
miss-islington deleted the backport-ba687d9-3.13 branch January 2, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @jaraco @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.