GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-123085: Fix issue in inferred caller when resources package has no source by jaraco · Pull Request #123102 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Aug 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

  • Await gh-121735: Fix module-adjacent references in zip files #123037

  • importlib.resources.files() doesn't work correctly when importlib library is compiled #123085: Fix issue in inferred caller when resources package has no source.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco jaraco changed the title Fix issue in inferred caller when resources package has no source gh-123085: Fix issue in inferred caller when resources package has no source Aug 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 17, 2024
importlib.resources.files() doesn't work correctly when importlib library is compiled #123085
Open
@jaraco jaraco added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Aug 17, 2024
@jaraco
jaraco marked this pull request as ready for review September 12, 2024 09:02
@jaraco
jaraco requested review from FFY00, brettcannon, ericsnowcurrently, erlend-aasland, ncoghlan and warsaw as code owners September 12, 2024 09:02
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 12, 2024
@jaraco
jaraco force-pushed the gh-123085/inferred-compiled branch from e4bfe86 to b6bd51d Compare September 12, 2024 09:18
@jaraco jaraco mentioned this pull request Sep 12, 2024
gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present #124018
Merged
1 task done
@jaraco
pythongh-123085: Fix issue in inferred caller when resources package …
097b06c 
…has no source.

From importlib_resources 6.4.3 (python/importlib_resources#314).
@jaraco
jaraco force-pushed the gh-123085/inferred-compiled branch from b6bd51d to 097b06c Compare September 12, 2024 18:38
@jaraco
Merge remote-tracking branch 'upstream/main' into pythongh-123085/inf…
5813584 
…erred-compiled
@jaraco

jaraco commented Sep 12, 2024

Copy link
Copy Markdown
Member Author

I'm proceeding with a merge to unblock #124018.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco enabled auto-merge (squash) September 12, 2024 18:49
@jaraco
jaraco merged commit a53812d into python:main Sep 12, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 12, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a53812df126b99bca25187441a123c7785ee82a0 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned jaraco Sep 12, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a53812df126b99bca25187441a123c7785ee82a0 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco deleted the gh-123085/inferred-compiled branch September 12, 2024 19:38
@jaraco

jaraco commented Sep 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The backport to 3.13 is blocked by:

  • Await [3.13] gh-121735: Fix module-adjacent references in zip files (GH-123037) #123986
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco added a commit to jaraco/cpython that referenced this pull request Sep 12, 2024
@jaraco
[3.12] pythongh-123085: Fix issue in inferred caller when resources p…
70b4561 
…ackage has no source (pythonGH-123102)

pythongh-123085: Fix issue in inferred caller when resources package has no source.

From importlib_resources 6.4.3 (python/importlib_resourcesGH-314).
(cherry picked from commit a53812d)

Co-authored-by: Jason R. Coombs <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

GH-124021 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 12, 2024
jaraco added a commit to jaraco/cpython that referenced this pull request Sep 12, 2024
@jaraco
[3.13] pythongh-123085: Fix issue in inferred caller when resource pa…
50c8d2d 
…ckage has no source (pythonGH-123102)
@jaraco jaraco mentioned this pull request Sep 12, 2024
[3.13] gh-123085: Fix issue in inferred caller when resource package has no source (GH-123102) #124024
Merged
1 task done
@bedevere-app

bedevere-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

GH-124024 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 12, 2024
@jaraco jaraco mentioned this pull request Jan 5, 2025
[3.12] gh-123085: Fix issue in inferred caller when resources package has no source (GH-123102) #124021
Merged
jaraco added a commit that referenced this pull request Jan 5, 2025
@jaraco
[3.12] gh-123085: Fix issue in inferred caller when resources package…
d712ece 
… has no source (GH-123102) (#124021)

gh-123085: Fix issue in inferred caller when resources package has no source.

From importlib_resources 6.4.3 (python/importlib_resourcesGH-314).
(cherry picked from commit a53812d)
jaraco added a commit that referenced this pull request Aug 15, 2025
@jaraco
[3.13] gh-123085: Fix issue in inferred caller when resource package …
0607fdd 
…has no source (GH-123102) (#124024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jaraco jaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.