GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97588: remove unused functions in _ctypes/cfield.c by iritkatriel · Pull Request #124010 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Sep 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member 
./Modules/_ctypes/cfield.c:49:12: warning: unused function 'round_down' [-Wunused-function]
Py_ssize_t round_down(Py_ssize_t numToRound, Py_ssize_t multiple)
           ^
./Modules/_ctypes/cfield.c:59:12: warning: unused function 'round_up' [-Wunused-function]
Py_ssize_t round_up(Py_ssize_t numToRound, Py_ssize_t multiple)
           ^
./Modules/_ctypes/cfield.c:409:12: warning: unused function 'BUILD_SIZE' [-Wunused-function]
Py_ssize_t BUILD_SIZE(Py_ssize_t bitsize, Py_ssize_t offset) {
  • Issue: ctypes: bit field data does not survive round trip #97588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-97588: remove unused functions in _ctypes/cfield.c
1e4525b
@iritkatriel iritkatriel added the skip news label Sep 12, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 12, 2024
ctypes: bit field data does not survive round trip #97588
Closed
@iritkatriel
iritkatriel requested review from encukou and vstinner September 12, 2024 15:05
@picnixz picnixz mentioned this pull request Sep 16, 2024
New build warnings: warning: unused function 'round_down' [-Wunused-function] #124122
Closed
@encukou
encukou merged commit 453da53 into python:main Sep 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 16, 2024
@encukou

encukou commented Sep 16, 2024

Copy link
Copy Markdown
Member

Thanks for the catch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Sep 16, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review: LGTM :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@iritkatriel @savannahostrowski
pythongh-97588: remove unused functions in _ctypes/cfield.c (pythonGH…
5e54211 
…-124010)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @encukou @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.