GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116622: Android test script improvements by mhsmith · Pull Request #124012 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Sep 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes or documents various issues encountered while setting up the Android buildbot.

  • Issue: Add support for Android as a target platform #116622

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mhsmith added 4 commits September 12, 2024 11:39
@mhsmith
Set Android test script stdout to line-buffered
acb3419
@mhsmith
Print warning logcat messages on stderr
8e4bebe
@mhsmith
Add a -vv option to display high-volume messages which are rarely useful
ae499f9
@mhsmith
Documentation and comment improvements
537e149
@mhsmith mhsmith added skip news needs backport to 3.13 only security fixes labels Sep 12, 2024
@bedevere-app bedevere-app Bot added the awaiting review label Sep 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 12, 2024
Add support for Android as a target platform #116622
Closed
mhsmith
mhsmith commented Sep 12, 2024
View reviewed changes
Comment thread Android/android.py
Comment on lines +583 to +585
"-v", "--verbose", action="count", default=0,
help="Show Gradle output, and non-Python logcat messages. "
"Use twice to include high-volume messages which are rarely useful.")

@mhsmith mhsmith Sep 12, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged, I'll switch the the buildbot over to -v mode so it will capture all non-Python log messages except the high-volume ones from test_syslog. These messages have been critical for understanding test failures in the past, including SELinux errors, low memory warnings, and signals being delivered to the wrong thread.

Since -v also displays the Gradle build log, there will no longer be any need for the buildbot to have a separate build_testbed step, hence the change to its comment above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
mhsmith requested a review from freakboy3742 September 12, 2024 16:10
freakboy3742
freakboy3742 approved these changes Sep 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 13, 2024
@freakboy3742
freakboy3742 merged commit 1f9d163 into python:main Sep 13, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 13, 2024

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2024
@mhsmith @miss-islington
pythongh-116622: Android test script improvements (pythonGH-124012)
4168d81 
* Set Android test script stdout to line-buffered
* Print warning logcat messages on stderr
* Add a -vv option to display high-volume messages which are rarely useful
* Documentation and comment improvements
(cherry picked from commit 1f9d163)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 13, 2024

Copy link
Copy Markdown

GH-124034 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 13, 2024
Yhg1s pushed a commit that referenced this pull request Sep 24, 2024
@miss-islington @mhsmith
[3.13] gh-116622: Android test script improvements (GH-124012) (#124034)
e9b531d 
gh-116622: Android test script improvements (GH-124012)

* Set Android test script stdout to line-buffered
* Print warning logcat messages on stderr
* Add a -vv option to display high-volume messages which are rarely useful
* Documentation and comment improvements
(cherry picked from commit 1f9d163)

Co-authored-by: Malcolm Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mhsmith @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.