GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-36346: Prepare for removing the legacy Unicode C API. by serhiy-storchaka · Pull Request #12409 · python/cpython

Conversation

serhiy-storchaka commented Mar 18, 2019 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.

https://bugs.python.org/issue36346

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-36346: Prepare for removing the legacy Unicode C API.

699e616

Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.

serhiy-storchaka added the DO-NOT-MERGE label

Mar 18, 2019

serhiy-storchaka requested review from a team, rhettinger and skrah as code owners

March 18, 2019 14:27

the-knights-who-say-ni added the CLA signed label

Mar 18, 2019

bedevere-bot added the awaiting merge label

Mar 18, 2019

scoder reviewed

Mar 18, 2019

View reviewed changes

scoder left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of code that will eventually be removed here. Nice!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/_ctypes/callproc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 9 commits

March 19, 2019 11:50


          Fix winreg.SetValue().

60b89c9


          Clean up some ifdefs in _testcapimodule.

f386b63


          Make path_cleanup() paranoidally safer.

11e0e0c


          Merge branch 'master' into disable-wchar-cache

236f608


          Fix os.scandir().

8750d48


          Merge branch 'master' into disable-wchar-cache

431e71f


          Merge branch 'master' into disable-wchar-cache

545c7a9


          Merge branch 'master' into disable-wchar-cache

3c1ab31


          Merge branch 'master' into disable-wchar-cache

54b0561

methane commented Jun 17, 2020

Copy link

Copy Markdown

Member

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'master' into disable-wchar-cache

2c62d96

serhiy-storchaka commented Jun 29, 2020

Copy link

Copy Markdown

Member Author

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

#21223

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 10 commits

June 30, 2020 09:16


          Merge branch 'master' into disable-wchar-cache

6d89775


          Silence compiler warnings.

3b5294a


          Fix PyUnicode_IsIdentifier for the cache-less build.

e7898fa


          Silence compiler warnings on Windows.

fd641c6


          Merge branch 'master' into disable-wchar-cache

a79d935


          Fix compiler warning in _testcapi.

ed14aa9


          Merge branch 'master' into disable-wchar-cache

c5eb102


          Merge branch 'master' into disable-wchar-cache

d529224


          Merge branch 'master' into disable-wchar-cache

6102b4b


          Merge branch 'master' into disable-wchar-cache

74695b3


          Use HAVE_UNICODE_WCHAR_CACHE instead of USE_UNICODE_WCHAR_CACHE in _P…

97b5228

…y_DumpASCII().

methane reviewed

Jul 6, 2020

View reviewed changes

Comment thread

Include/cpython/unicodeobject.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 8 commits

July 9, 2020 11:03


          Set HAVE_UNICODE_WCHAR_CACHE and USE_UNICODE_WCHAR_CACHE only if they…

d6ba6b7

… were not set.


          Remove Py_UNICODE_MATCH.

0da4146


          Merge branch 'master' into disable-wchar-cache

51365fb


          Fix unterminated #if.

e425908


          Reset arraymodule.c.

8a9259b


          Merge branch 'master' into disable-wchar-cache

76ba4b6


          Temporary disable the wchar_t cache by default.

16ac7fd


          Fix unicode_result().

5e90bf8

blesnatalman approved these changes

Jul 10, 2020

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting merge labels

Jul 10, 2020

blesnatalman approved these changes

Jul 10, 2020

View reviewed changes


          Merge branch 'master' into disable-wchar-cache

09675ab

blesnatalman approved these changes

Jul 10, 2020

View reviewed changes


          Merge branch 'master' into disable-wchar-cache

6915ce3

iritkatriel commented Apr 11, 2022

Copy link

Copy Markdown

Member

https://bugs.python.org/issue36346 is closed. What is the status of this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rhettinger removed request for rhettinger and skrah

May 3, 2022 06:23

serhiy-storchaka mentioned this pull request

May 11, 2022

gh-92536: PEP 623: Remove wstr from unicode #92537

Merged

serhiy-storchaka commented May 12, 2022

Copy link

Copy Markdown

Member Author

No longer actual after merging #92537.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka closed this

May 12, 2022

serhiy-storchaka deleted the disable-wchar-cache branch

May 12, 2022 11:30

bedevere-bot mentioned this pull request

Apr 10, 2022

Prepare for removing the legacy Unicode C API #80527

Closed

Reviewers

methane

methane left review comments

scoder

scoder left review comments

+1 more reviewer

blesnatalman

blesnatalman approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Mar 18, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scoder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

methane commented Jun 17, 2020

Uh oh!

serhiy-storchaka commented Jun 29, 2020

Uh oh!

Uh oh!

iritkatriel commented Apr 11, 2022

Uh oh!

serhiy-storchaka commented May 12, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

serhiy-storchaka commented Mar 18, 2019 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.