GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-92536: PEP 623: Remove wstr from unicode by methane · Pull Request #92537 · python/cpython Conversation
methane
force-pushed
the
remove-unicode-wchar
branch
from
390915a to
eda0fb0
Compare
methane
force-pushed
the
remove-unicode-wchar
branch
from
eda0fb0 to
d5a14c2
Compare
methane
commented
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Huge number of code using this API.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This API
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
methane
marked this pull request as ready for review
arhadthedev
reviewed
Uh oh!
There was an error while loading. Please reload this page. Co-authored-by: Oleg Iarygin <[email protected]>
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nothing wrong stood out after a quick scan on my phone. The change seems mostly mechanical and limited to removals. Is that right? Also, should the PEP be mentioned more prominently in the Misc/NEWS entry and whats_new?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Argument Clinic How-To also needs an update: diff --git a/Doc/howto/clinic.rst b/Doc/howto/clinic.rst index 04b1a2cac0..b969dc8f42 100644 --- a/Doc/howto/clinic.rst +++ b/Doc/howto/clinic.rst @@ -848,15 +848,11 @@ on the right is the text you'd replace it with. ``'s#'`` ``str(zeroes=True)`` ``'s*'`` ``Py_buffer(accept={buffer, str})`` ``'U'`` ``unicode`` -``'u'`` ``Py_UNICODE`` -``'u#'`` ``Py_UNICODE(zeroes=True)`` ``'w*'`` ``Py_buffer(accept={rwbuffer})`` ``'Y'`` ``PyByteArrayObject`` ``'y'`` ``str(accept={bytes})`` ``'y#'`` ``str(accept={robuffer}, zeroes=True)`` ``'y*'`` ``Py_buffer`` -``'Z'`` ``Py_UNICODE(accept={str, NoneType})`` -``'Z#'`` ``Py_UNICODE(accept={str, NoneType}, zeroes=True)`` ``'z'`` ``str(accept={str, NoneType})`` ``'z#'`` ``str(accept={str, NoneType}, zeroes=True)`` ``'z*'`` ``Py_buffer(accept={buffer, str, NoneType})`` |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I think it is very difficult to maintain both of HAVE_UNICODE_WCHAR_CACHE is 0 and 1.
AC supports u and Z even after removing wstr. I will replace Py_UNICODE with wchar_t in the clinic howto. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Implemented in python/cpython#92537
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
some optional grammar changes if you revisit some of these files later down the line
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| encoding passed in as parameter. | ||
|
|
||
| .. versionchanged:: 3.12 | ||
| ``u``, ``u#``, ``Z``, and ``Z#`` are removed because they used legacy ``Py_UNICODE*`` |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
... because they used a/the legacy ...
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I made follow-up PR: #92756
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| .. versionadded:: 3.3 | ||
|
|
||
| .. deprecated:: 3.10 | ||
| This API do nothing since Python 3.12. Please remove code using this function. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This API does nothing..., and I think the 'Please remove ...' can be omitted
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Congratulations for finally managing to remove this legacy API. A big thank you! I hated this API since Python 3.3, having to call "PyUnicode_Ready()" was super annoying. Thanks for you tenacity to remove it! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* PEP 623: Mark it final Implemented in python/cpython#92537 * Add Discussions-To and Resolution header * Fix Discussions-To link
I'm sorry but I am considering to un-deprecate |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.