GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix `make htmllive` target by zware · Pull Request #124219 · python/cpython

Conversation

@zware

@zware zware commented Sep 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--124219.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
Allow make -C Doc htmllive to work without manual venv activation
6bc1152 
Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
@zware zware added docs Documentation in the Doc dir skip issue skip news labels Sep 18, 2024
@zware
zware requested a review from colesbury September 18, 2024 20:39
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 18, 2024
colesbury
colesbury approved these changes Sep 18, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This fixes make htmllive for me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 18, 2024
AA-Turner
AA-Turner approved these changes Sep 18, 2024
View reviewed changes
@zware
zware enabled auto-merge (squash) September 18, 2024 20:45
hugovk
hugovk approved these changes Sep 18, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware zware added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 18, 2024
@zware
zware merged commit 9a6e233 into python:main Sep 18, 2024
@zware
zware deleted the fix_doc_make_htmllive_target branch September 18, 2024 21:02
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 18, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
@zware @miss-islington
Fix make htmllive target (pythonGH-124219)
effe2c2 
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

GH-124221 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
@zware @miss-islington
Fix make htmllive target (pythonGH-124219)
183bc9a 
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 18, 2024
@bedevere-app

bedevere-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

GH-124222 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 18, 2024
@hugovk hugovk mentioned this pull request Sep 20, 2024
Infra: Update Makefileto match CPython/Docs and devguide python/peps#3985
Merged
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@zware @savannahostrowski
Fix make htmllive target (pythonGH-124219)
f1f7e29 
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
@miss-islington @zware
[3.13] Fix make htmllive target (GH-124219) (#124221)
057f3fa 
Fix `make htmllive` target (GH-124219)

Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zware @colesbury @hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.