GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124217: Add RFC 9637 reserved IPv6 block `3fff::/20` by y5c4l3 · Pull Request #124240 · python/cpython

Conversation

@y5c4l3

@y5c4l3 y5c4l3 commented Sep 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml

  • Issue: RFC 9637 not implemented by ipaddress module #124217

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting review label Sep 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2024
RFC 9637 not implemented by ipaddress module #124217
Closed
ZeroIntensity
ZeroIntensity approved these changes Sep 19, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are all passing and there's nothing here that I'm concerned about.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 19, 2024
@ZeroIntensity ZeroIntensity added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 19, 2024
vstinner
vstinner reviewed Sep 20, 2024
View reviewed changes
Comment thread Lib/test/test_ipaddress.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/ipaddress.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2024-09-19-20-15-00.gh-issue-124217.j0KlQB.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@y5c4l3
y5c4l3 force-pushed the ipv6-rfc9637 branch from 9c44ccb to 1f645c1 Compare September 20, 2024 10:30
@y5c4l3
Add RFC 9637 reserved IPv6 block 3fff::/20
d50453c 
Signed-off-by: y5c4l3 <[email protected]>
@y5c4l3
y5c4l3 force-pushed the ipv6-rfc9637 branch from 1f645c1 to d50453c Compare September 20, 2024 10:30
@vstinner
vstinner enabled auto-merge (squash) September 20, 2024 10:33
vstinner
vstinner approved these changes Sep 20, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 20, 2024
@vstinner
vstinner merged commit db6eb36 into python:main Sep 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 20, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 20, 2024

Copy link
Copy Markdown

Thanks @y5c4l3 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2024
@y5c4l3 @miss-islington
pythongh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::/…
3180813 
…20` (pythonGH-124240)

(cherry picked from commit db6eb36)

Co-authored-by: Y5 <[email protected]>
Signed-off-by: y5c4l3 <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 20, 2024

Copy link
Copy Markdown

GH-124282 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 20, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2024
@y5c4l3 @miss-islington
pythongh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::/…
e86bf6b 
…20` (pythonGH-124240)

(cherry picked from commit db6eb36)

Co-authored-by: Y5 <[email protected]>
Signed-off-by: y5c4l3 <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 20, 2024

Copy link
Copy Markdown

GH-124283 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 20, 2024
vstinner pushed a commit that referenced this pull request Sep 20, 2024
@miss-islington @y5c4l3
[3.12] gh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::…
fcfe786 
…/20` (GH-124240) (#124283)

gh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::/20` (GH-124240)
(cherry picked from commit db6eb36)

Signed-off-by: y5c4l3 <[email protected]>
Co-authored-by: Y5 <[email protected]>
@vstinner

vstinner commented Sep 20, 2024

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@y5c4l3 @savannahostrowski
pythongh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::/…
c249d42 
…20` (python#124240)

Signed-off-by: y5c4l3 <[email protected]>
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@y5c4l3 @savannahostrowski
pythongh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::/…
4dacd62 
…20` (python#124240)

Signed-off-by: y5c4l3 <[email protected]>
vstinner pushed a commit that referenced this pull request Oct 7, 2024
@miss-islington @y5c4l3
[3.13] gh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::…
a93716f 
…/20` (GH-124240) (#124282)

gh-124217, ipaddress: Add RFC 9637 reserved IPv6 block `3fff::/20` (GH-124240)
(cherry picked from commit db6eb36)

Signed-off-by: y5c4l3 <[email protected]>
Co-authored-by: Y5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@y5c4l3 @vstinner @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.