GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-116622: Complete Android documentation by mhsmith · Pull Request #124259 · python/cpython

Conversation

mhsmith commented Sep 20, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

The Android x86_64 buildbot is not yet up and running, so the statement that "Android is now a PEP 11 supported platform" is not quite ready to be merged, but I'd like to get an early review.

Summary:

Add an Android page to the "Setup and Usage" section.
Generalize the "Notes on availability" section to cover both iOS and Android.
Add "availability" markers to the modules and functions not supported on Android.

Issue: Add support for Android as a target platform #116622

📚 Documentation preview 📚: https://cpython-previews--124259.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhsmith added 6 commits

September 19, 2024 19:44


          Add Android to docs of unsupported features it shares with iOS

8015ef4


          Add additional markers for unsupported features on Android

2e08c09


          Clarify emulator RAM size instructions

0f8c9da


          Add Android platform guide

879c805


          Update whatsnew and ACKS

98d7216


          Various fixes

2c6ec29

mhsmith requested review from abalkin, corona10, erlend-aasland, freakboy3742, gpshead, pfmoore, pganssle, pradyunsg, serhiy-storchaka and vsajip as code owners

September 20, 2024 00:11

bedevere-app Bot added the awaiting review label

Sep 20, 2024

bedevere-app Bot mentioned this pull request

Sep 20, 2024

Add support for Android as a target platform #116622

Closed

mhsmith added the needs backport to 3.13 only security fixes label

Sep 20, 2024

mhsmith mentioned this pull request

Sep 20, 2024

PEP 738: Mark as Final python/peps#3982

Merged

6 tasks done

freakboy3742 approved these changes

Sep 20, 2024

View reviewed changes

freakboy3742 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me from a technical perspective; I'd like someone with more of a documentation eye (@hugovk?) to weigh in on any of the markup and layout aspects.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Sep 20, 2024

serhiy-storchaka approved these changes

Sep 22, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not expert in Android, WASM or iOS, but this LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/using/android.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/using/android.rst


		* `Briefcase <https://briefcase.readthedocs.io>`__, from the BeeWare project
		* `Buildozer <https://buildozer.readthedocs.io>`__, from the Kivy project
		* `Chaquopy <https://chaquo.com/chaquopy>`__

serhiy-storchaka Sep 22, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are affiliated with this, right? I do not think there is a problem here, taking into account open-sourcing Chaquopy and your contribution in CPython.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

freakboy3742 Sep 23, 2024

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - Malcolm is the founder of Chaquopy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhsmith Sep 23, 2024

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've expanded this list to include all the production-quality Python-on-Android tools that I'm aware of.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reviewed

Sep 23, 2024

View reviewed changes

AA-Turner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner removed request for abalkin, gpshead, pfmoore, pganssle and vsajip

September 23, 2024 15:13

AA-Turner requested review from AA-Turner and removed request for corona10, erlend-aasland and pradyunsg

September 23, 2024 15:13

freakboy3742 reviewed

Sep 23, 2024

View reviewed changes

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 reviewed

Sep 23, 2024

View reviewed changes

Comment thread

Doc/using/android.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Updates from code review.

35384ab

freakboy3742 reviewed

Sep 23, 2024

View reviewed changes

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 and others added 4 commits

September 23, 2024 09:30


          Correct markup

023598c


          Merge branch 'main' into android-docs

9803d40


          List more recommended Android tools

a5190e5


          Merge branch 'main' into android-docs

e241163

Yhg1s commented Sep 23, 2024

Copy link

Copy Markdown

Member

Russel mentioned the android buildbot is now all set up and working, so is this ready to go in? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 commented Sep 23, 2024

Copy link

Copy Markdown

Contributor

@Yhg1s 2 Android buildbots are up and running:

The failures on the arm64 buildbot occur inconsistently; they would be been addressed by #123988, #124034, and #124035. Those 3 PRs alter the test suite and the Android test runner to make test conditions reproducible.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reviewed

Sep 23, 2024

View reviewed changes

Comment thread

Android/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Android/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Android/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/includes/wasm-mobile-notavail.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/dbm.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/intro.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/using/android.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/using/android.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/using/android.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

mhsmith and others added 4 commits

September 23, 2024 23:16


          Apply suggestions from code review

99e4c12

Co-authored-by: Adam Turner <[email protected]>


          Improve formatting

eabbf45


          Use consistent order in wasm-mobile-notavail.rst

7fd73d1


          List Android under "Build Changes" in whatsnew

33efbf0

AA-Turner approved these changes

Sep 23, 2024

View reviewed changes

AA-Turner enabled auto-merge (squash)

September 23, 2024 22:55

AA-Turner added the docs Documentation in the Doc dir label

Sep 23, 2024

AA-Turner merged commit e80dd30 into python:main

Sep 23, 2024

miss-islington-app Bot commented Sep 23, 2024

Copy link

Copy Markdown

Thanks @mhsmith for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Sep 23, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 23, 2024


          pythongh-116622: Complete Android documentation (pythonGH-124259)

4a3b708

(cherry picked from commit e80dd30)

Co-authored-by: Malcolm Smith <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
Co-authored-by: Adam Turner <[email protected]>

bedevere-app Bot commented Sep 23, 2024

Copy link

Copy Markdown

GH-124395 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Sep 23, 2024

Yhg1s added a commit that referenced this pull request

Sep 24, 2024


          [3.13] gh-116622: Complete Android documentation (GH-124259) (#124395)

9a60a9d

gh-116622: Complete Android documentation (GH-124259)
(cherry picked from commit e80dd30)

Co-authored-by: Malcolm Smith <[email protected]>
Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
Co-authored-by: Adam Turner <[email protected]>

Reviewers

freakboy3742

freakboy3742 approved these changes

serhiy-storchaka

serhiy-storchaka approved these changes

AA-Turner

AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mhsmith commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

serhiy-storchaka Sep 22, 2024

Choose a reason for hiding this comment

Uh oh!

freakboy3742 Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

mhsmith Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AA-Turner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yhg1s commented Sep 23, 2024

Uh oh!

freakboy3742 commented Sep 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Sep 23, 2024

Uh oh!

bedevere-app Bot commented Sep 23, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mhsmith commented Sep 20, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.