GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid continuous output. by terryjreedy · Pull Request #124310 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Sep 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS. While theoretically correct, the result was Shell freezing when receiving continuous short strings to print. Test: while 1: 1.

The guess is that there is no idle time in which to do the screen update. Reverting the change in one of the files,
outwin, fixes the issue. Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update' to 'update_idletasks on the text used for testing.

  • Issue: IDLE: infinite print loop hangs and crashes #112938

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
terryjreedy added 3 commits September 21, 2024 22:13
@terryjreedy
pythongh-112938: IDLE - revert '_idletasks' addition in outwin
747947f
pythongh-88496 replaced text.update with text.update_idletasks
in two files to fix test failures on macOS.  While
theoretically correct, the result was Shell freezing when
receiving continuous short strings to print.

The guess is that there was no idle time in which to do
the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.

The test will be patched as needed on macOS.
@terryjreedy
Fix tests on mac for idletasks reversion
150bf2e
@terryjreedy
blurb
13e5902
@terryjreedy terryjreedy added topic-IDLE needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 22, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 22, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 22, 2024
IDLE: infinite print loop hangs and crashes #112938
Closed
@terryjreedy
terryjreedy merged commit d5f95ec into python:main Sep 22, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 22, 2024

Copy link
Copy Markdown

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 22, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2024
@terryjreedy @miss-islington
pythongh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid…
9d4db0a
… continuous output. (pythonGH-124310)

python#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS.  While theoretically correct, the result was Shell freezing when receiving continuous short strings to print.  Test: `while 1: 1`.

The guess is that there is no idle time in which to do the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.  Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update'
to 'update_idletasks on the text used for testing.
(cherry picked from commit d5f95ec)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 22, 2024

Copy link
Copy Markdown

GH-124318 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 22, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2024
@terryjreedy @miss-islington
pythongh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid…
a0a40e0
… continuous output. (pythonGH-124310)

python#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS.  While theoretically correct, the result was Shell freezing when receiving continuous short strings to print.  Test: `while 1: 1`.

The guess is that there is no idle time in which to do the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.  Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update'
to 'update_idletasks on the text used for testing.
(cherry picked from commit d5f95ec)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 22, 2024

Copy link
Copy Markdown

GH-124319 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 22, 2024
@terryjreedy
terryjreedy deleted the loophang branch September 22, 2024 19:52
terryjreedy added a commit that referenced this pull request Sep 22, 2024
@miss-islington @terryjreedy
[3.12] gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapi…
cf39a5f
…d continuous output. (GH-124310) (#124319)

gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid continuous output. (GH-124310)

#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS.  While theoretically correct, the result was Shell freezing when receiving continuous short strings to print.  Test: `while 1: 1`.

The guess is that there is no idle time in which to do the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.  Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update'
to 'update_idletasks on the text used for testing.
(cherry picked from commit d5f95ec)

Co-authored-by: Terry Jan Reedy <[email protected]>
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@terryjreedy @savannahostrowski
pythongh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid…
af14a44
… continuous output. (python#124310)

python#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS.  While theoretically correct, the result was Shell freezing when receiving continuous short strings to print.  Test: `while 1: 1`.

The guess is that there is no idle time in which to do the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.  Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update'
to 'update_idletasks on the text used for testing.
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@terryjreedy @savannahostrowski
pythongh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid…
5b1f2b2
… continuous output. (python#124310)

python#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS.  While theoretically correct, the result was Shell freezing when receiving continuous short strings to print.  Test: `while 1: 1`.

The guess is that there is no idle time in which to do the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.  Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update'
to 'update_idletasks on the text used for testing.
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @terryjreedy
[3.13] gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapi…
845e039
…d continuous output. (GH-124310) (#124318)

gh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid continuous output. (GH-124310)

#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS.  While theoretically correct, the result was Shell freezing when receiving continuous short strings to print.  Test: `while 1: 1`.

The guess is that there is no idle time in which to do the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.  Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update'
to 'update_idletasks on the text used for testing.
(cherry picked from commit d5f95ec)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-IDLE

Projects

IDLE Issues
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.