GeezerVison is showing github.com — GH-109975: Copyedit 3.13 What's New: C API by AA-Turner · Pull Request #124313 · python/cpython
Conversation
AA-Turner
commented
Sep 22, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Some lines look too long, and some lines look unnecessary short. Could you please reformat the text using the recommended maximal line length (I think 79 from PEP 12 is applied here)?
Alphabetical order is perhaps necessary for such large number of changes, but in some cases I think that it would be better to group semantically close changes together. For example, PyObject_GenericHash and Py_HashPointer. Or PyMapping_GetOptionalItem, which is close to PyDict_* changes and to PyObject_GetOptionalAttr, and to PyMapping_HasKeyWithError. But I do not see a way how this can be improved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* PyDict*: PyMapping_GetOptionalItem and PyObject_GetOptionalAttr
* Py_HashPointer and Py_HashPointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I've pushed two commits.
Some lines look too long, and some lines look unnecessary short. Could you please reformat the text using the recommended maximal line length (I think 79 from PEP 12 is applied here)?
The devguide also says 79/80, but in a few places I've gone a couple of characters over to avoid a mostly empty orphan line.
I've rebalanced the particularly egregious case you pointed out, but breaking lines early is a somewhat intentional choice (some people call it semantic line breaks) where I break the line at punctuation or a clause in a sentence. This tends to lead to smaller diffs later down the line, as re-wrapping an entire paragraph for changing a single word can be avoided.
(This is of course only visible in the .rst -- the vast majority readers will never know which lines were broken where in the HTML or PDF output)
A
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9d0a75269c6ae361b1ed5910c3b3424ed93b6f6d 3.13
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|