GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124682: Disable test that is prone to intermittent failure on iOS. by freakboy3742 · Pull Request #124683 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Sep 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

test_support.test_fd_count is prone to intermittent failure (3 times in over 1400 runs) because an iOS app has other threads running that can modify file handles. The test is already skipped on Emscripten and WASI for similar reasons.

  • Issue: Intermittent test_support.test_fd_count failure on iOS #124682

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
Disable test that is prone to intermittent failure on iOS.
aea4a5f
@freakboy3742 freakboy3742 added skip news 3.13 only security fixes OS-ios 3.14 bugs and security fixes needs backport to 3.13 only security fixes labels Sep 27, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 27, 2024
@freakboy3742

freakboy3742 commented Sep 27, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2024
Intermittent test_support.test_fd_count failure on iOS #124682
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Sep 27, 2024
@bedevere-bot

bedevere-bot commented Sep 27, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit aea4a5f 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742
freakboy3742 requested a review from ned-deily September 27, 2024 17:42
@freakboy3742 freakboy3742 mentioned this pull request Sep 27, 2024
gh-116510: Fix crash due to shared immortal interned strings. #124646
Merged
ned-deily
ned-deily approved these changes Sep 27, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 27, 2024
@freakboy3742
freakboy3742 merged commit 10d504a into python:main Sep 27, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 27, 2024
@freakboy3742
freakboy3742 deleted the skip-fd-test branch September 27, 2024 17:49
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@freakboy3742 @miss-islington
pythongh-124682: Disable test that is prone to intermittent failure o…
889f270 
…n iOS. (pythonGH-124683)

Disable test that is prone to intermittent failure on iOS.
(cherry picked from commit 10d504a)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124687 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 27, 2024
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @freakboy3742
[3.13] gh-124682: Disable test that is prone to intermittent failure …
dff48e1 
…on iOS. (GH-124683) (#124687)

gh-124682: Disable test that is prone to intermittent failure on iOS. (GH-124683)

Disable test that is prone to intermittent failure on iOS.
(cherry picked from commit 10d504a)

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes 3.14 bugs and security fixes OS-ios skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@freakboy3742 @bedevere-bot @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.