GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124102: Update internal PCbuild docs and correct WiX registry by Wulian233 · Pull Request #124784 · python/cpython

Conversation

@Wulian233

@Wulian233 Wulian233 commented Sep 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

skip news
@zooba I got something wrong in the previous PR

  • Corrected the incorrect information in the previous PR
2024-09-30 182656
  • Fixed the incorrect WiX 3.14 registry.
  • Issue: Update Dependency Information for PCBuild to Correct Information #124102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Wulian233
Update Dependency Information for PCBuild to Correct Information
c738e9f
@Wulian233
Wulian233 requested a review from a team as a code owner September 30, 2024 11:20
@bedevere-app bedevere-app Bot added the awaiting review label Sep 30, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 30, 2024
Update Dependency Information for PCBuild to Correct Information #124102
Closed
@Wulian233
remove win8.1
d857f57
@Wulian233 Wulian233 mentioned this pull request Oct 1, 2024
remove win7 and win8 msu python/cpython-bin-deps#5
Closed
@Wulian233
finish
96a6a88
zooba
zooba reviewed Oct 1, 2024
View reviewed changes
Comment thread Tools/msi/wix.props Resolved

Uh oh!

There was an error while loading. Please reload this page.
Wulian233 added 2 commits October 2, 2024 08:57
@Wulian233
Merge branch 'python:main' into pcbuild
e26e048
@Wulian233
WixInstallPath environment variable
470c183
zooba
zooba reviewed Oct 2, 2024
View reviewed changes
Comment thread Doc/using/windows.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233
update windows.rst
31bfa66
@Wulian233
Wulian233 requested a review from zooba October 4, 2024 01:38
@Wulian233

Wulian233 commented Oct 13, 2024

Copy link
Copy Markdown
Contributor Author

@zooba Could you please review this again? I have already resolved the issues mentioned :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233 Wulian233 changed the title gh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency Information gh-124102: Update internal PCbuild docs and correct WiX registry Oct 14, 2024
@zooba zooba added the skip news label Oct 18, 2024
@zooba
zooba merged commit cda0ec8 into python:main Oct 18, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 18, 2024
@Wulian233
Wulian233 deleted the pcbuild branch October 18, 2024 13:15
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@Wulian233 @ebonnal
pythongh-124102: Clean up unsupported VS and WiX detections (pythonGH…
7e08032 
…-124784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Wulian233 @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.