GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124613: Don't run perf tests in JIT builds by pablogsal · Pull Request #124792 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Sep 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_perf_profiler fails on Linux (both AArch64 and x86) #124613

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested review from ambv and lysnikolaou as code owners September 30, 2024 17:07
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 30, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 30, 2024
test_perf_profiler fails on Linux (both AArch64 and x86) #124613
Closed
@pablogsal
pythongh-124613: Don't run perf tests in JIT builds
3e7ccf0 
Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the gh-124613 branch from 14e6f79 to 3e7ccf0 Compare September 30, 2024 17:07
vstinner
vstinner approved these changes Sep 30, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just suggested some minor changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_perf_profiler.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_perf_profiler.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 30, 2024
@pablogsal
pablogsal requested review from corona10 and erlend-aasland as code owners September 30, 2024 17:23
@pablogsal @vstinner
Apply suggestions from code review
851f12c 
Co-authored-by: Victor Stinner <[email protected]>
@pablogsal
pablogsal force-pushed the gh-124613 branch from 7d251d4 to 851f12c Compare September 30, 2024 17:24
@pablogsal pablogsal added the skip news label Sep 30, 2024
@pablogsal
pablogsal enabled auto-merge (squash) September 30, 2024 17:30
@pablogsal pablogsal added the needs backport to 3.13 only security fixes label Sep 30, 2024
@pablogsal
pablogsal merged commit 35541c4 into python:main Sep 30, 2024
@pablogsal
pablogsal deleted the gh-124613 branch September 30, 2024 17:57
@miss-islington-app

miss-islington-app Bot commented Sep 30, 2024

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 30, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 30, 2024

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 35541c410d894d4fa18002f7fdbebfe522f8320e 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned pablogsal Sep 30, 2024
@brandtbucher

brandtbucher commented Sep 30, 2024

Copy link
Copy Markdown
Member

If we don't want to skip these on most builds, we could decorate the tests with test.support.without_optimizer. See #124794 (comment).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Your Name
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
ad2155f 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Your Name
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
c468736 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Your Name
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
ced869b 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Your Name
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
7b082c9 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Your Name
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
81f2b81 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Your Name
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
857eaed 
…24792)"

This reverts commit 35541c4.
@pablogsal pablogsal mentioned this pull request Oct 1, 2024
🔄 Revert: gh-124613: Don't run perf tests in JIT builds (#124792) #124870
Closed
@hugovk hugovk removed the needs backport to 3.13 only security fixes label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou
@ambv ambv Awaiting requested review from ambv
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland
@corona10 corona10 Awaiting requested review from corona10

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @brandtbucher @vstinner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.