GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-124613: Deactivate perf support in tests if the jit is set by pablogsal · Pull Request #124794 · python/cpython

gh-124613: Deactivate perf support in tests if the jit is set #124794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

pablogsal merged 1 commit into python:main from pablogsal:gh-124613-2

Oct 4, 2024

Uh oh!

There was an error while loading. Please reload this page.

Merged

gh-124613: Deactivate perf support in tests if the jit is set #124794

Changes from all commits

Commits

Show all changes

1 commit

Select commit

fdd1068

gh-124613: Deactivate the JIT during perf tests

pablogsal Oct 1, 2024

File filter

Filter by extension .py (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

25 changes: 12 additions & 13 deletions 25 Lib/test/test_perf_profiler.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -23,15 +23,6 @@
		raise unittest.SkipTest("test crash randomly on ASAN/MSAN/UBSAN build")


		def is_jit_build():
		cflags = (sysconfig.get_config_var("PY_CORE_CFLAGS") or '')
		return "_Py_JIT" in cflags


		if is_jit_build():
		raise unittest.SkipTest("Perf support is not available in JIT builds")


		def supports_trampoline_profiling():
		perf_trampoline = sysconfig.get_config_var("PY_HAVE_PERF_TRAMPOLINE")
		if not perf_trampoline:
Expand Down Expand Up		@@ -71,11 +62,13 @@ def baz():
		"""
		with temp_dir() as script_dir:
		script = make_script(script_dir, "perftest", code)
		env = {**os.environ, "PYTHON_JIT": "0"}
		with subprocess.Popen(
		[sys.executable, "-Xperf", script],
		text=True,
		stderr=subprocess.PIPE,
		stdout=subprocess.PIPE,
		env=env,
		) as process:
		stdout, stderr = process.communicate()

Expand Down Expand Up		@@ -139,11 +132,13 @@ def baz():
		"""
		with temp_dir() as script_dir:
		script = make_script(script_dir, "perftest", code)
		env = {**os.environ, "PYTHON_JIT": "0"}
		with subprocess.Popen(
		[sys.executable, "-Xperf", script],
		text=True,
		stderr=subprocess.PIPE,
		stdout=subprocess.PIPE,
		env=env,
		) as process:
		stdout, stderr = process.communicate()

Expand Down Expand Up		@@ -188,11 +183,13 @@ def baz():
		"""
		with temp_dir() as script_dir:
		script = make_script(script_dir, "perftest", code)
		env = {**os.environ, "PYTHON_JIT": "0"}
		with subprocess.Popen(
		[sys.executable, script],
		text=True,
		stderr=subprocess.PIPE,
		stdout=subprocess.PIPE,
		env=env,
		) as process:
		stdout, stderr = process.communicate()

Expand Down Expand Up		@@ -269,8 +266,9 @@ def perf_command_works():
		"-c",
		'print("hello")',
		)
		env = {**os.environ, "PYTHON_JIT": "0"}
		stdout = subprocess.check_output(
		cmd, cwd=script_dir, text=True, stderr=subprocess.STDOUT
		cmd, cwd=script_dir, text=True, stderr=subprocess.STDOUT, env=env
		)
		except (subprocess.SubprocessError, OSError):
		return False
Expand All		@@ -282,11 +280,10 @@ def perf_command_works():


		def run_perf(cwd, args, use_jit=False, *env_vars):
		env = os.environ.copy()
		if env_vars:
		env = os.environ.copy()
		env.update(env_vars)
		else:
		env = None
		env["PYTHON_JIT"] = "0"
		output_file = cwd + "/perf_output.perf"
		if not use_jit:
		base_cmd = ("perf", "record", "-g", "--call-graph=fp", "-o", output_file, "--")
Expand Down Expand Up		@@ -455,11 +452,13 @@ def compile_trampolines_for_all_functions():

		with temp_dir() as script_dir:
		script = make_script(script_dir, "perftest", code)
		env = {**os.environ, "PYTHON_JIT": "0"}
		with subprocess.Popen(
		[sys.executable, "-Xperf", script],
		universal_newlines=True,
		stderr=subprocess.PIPE,
		stdout=subprocess.PIPE,
		env=env,
		) as process:
		stdout, stderr = process.communicate()

Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.