GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)" (gh-124807) by Yhg1s · Pull Request #124818 · python/cpython

Conversation

@Yhg1s

@Yhg1s Yhg1s commented Oct 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Revert "gh-116510: Fix crash due to shared immortal interned strings. (gh-124646)"

This reverts commit 98b2ed7.
(cherry picked from commit 7bdfabe)

  • Issue: [TraceRefs build] Tests fail: _PyRefchain_Remove: Assertion `value == REFCHAIN_VALUE' failed #124785

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yhg1s
[3.12] pythongh-124785: Revert "pythongh-116510: Fix crash due to sha…
1f0e989 
…red immortal interned strings (pythongh-124646)" (pythongh-124807)

Revert "pythongh-116510: Fix crash due to shared immortal interned strings. (pythongh-124646)"

This reverts commit 98b2ed7.
(cherry picked from commit 7bdfabe)

Co-authored-by: T. Wouters <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 1, 2024
This was referenced Oct 1, 2024
gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)" #124807
Merged
[TraceRefs build] Tests fail: _PyRefchain_Remove: Assertion `value == REFCHAIN_VALUE' failed #124785
Closed
@Yhg1s

Yhg1s commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

Already resolved in #124814.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s Yhg1s closed this Oct 1, 2024
rruuaanng
rruuaanng reviewed Oct 1, 2024
View reviewed changes
Comment thread Objects/unicodeobject.c
if (interned == NULL) {
return -1;
}
PyObject *interned = interned = PyDict_New();

@rruuaanng rruuaanng Oct 1, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to do this? Rather than

PyObject *interned = PyDict_New();

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@nascheme nascheme Oct 1, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a straight reversion of my change so that matches the previous code. I agree with you though, looks odd to write it that way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Yhg1s Yhg1s Oct 1, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a revert. Even worse, it's a backport of a revert. That's what the original code was. I imagine it was a mistake in the original PR (#102339) but that, too, may have been moved from somewhere else.

If you want to send a PR to fix it (in main) I'm sure Eric wouldn't mind reviewing :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yhg1s
Yhg1s deleted the backport-7bdfabe-3.12 branch August 13, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nascheme nascheme nascheme left review comments
+1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Yhg1s @nascheme @rruuaanng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.