GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)" by Yhg1s · Pull Request #124807 · python/cpython

Conversation

@Yhg1s

@Yhg1s Yhg1s commented Sep 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Revert the fix for gh-116510, since it causes crashes in the tracerefs build (and it makes invalid assumptions; see #124796 (comment)).

  • Issue: [TraceRefs build] Tests fail: _PyRefchain_Remove: Assertion `value == REFCHAIN_VALUE' failed #124785

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yhg1s
Revert "pythongh-116510: Fix crash due to shared immortal interned st…
48522a8 
…rings. (pythongh-124646)"

This reverts commit 98b2ed7.
@Yhg1s Yhg1s added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 30, 2024
@Yhg1s Yhg1s assigned nascheme Sep 30, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 30, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 30, 2024
[TraceRefs build] Tests fail: _PyRefchain_Remove: Assertion `value == REFCHAIN_VALUE' failed #124785
Closed
@nascheme

nascheme commented Sep 30, 2024

Copy link
Copy Markdown
Member

LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nascheme nascheme removed their assignment Sep 30, 2024
@nascheme
nascheme merged commit 7bdfabe into python:main Sep 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 30, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 30, 2024

Copy link
Copy Markdown

Thanks @Yhg1s for the PR, and @nascheme for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2024
@Yhg1s @miss-islington
pythongh-124785: Revert "pythongh-116510: Fix crash due to shared imm…
7745b1d 
…ortal interned strings (pythongh-124646)" (pythongh-124807)

Revert "pythongh-116510: Fix crash due to shared immortal interned strings. (pythongh-124646)"

This reverts commit 98b2ed7.
(cherry picked from commit 7bdfabe)

Co-authored-by: T. Wouters <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Sep 30, 2024

Copy link
Copy Markdown

Sorry, @Yhg1s and @nascheme, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7bdfabe2d1ec353ecdc75a5aec41cce83e572391 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned nascheme Sep 30, 2024
@bedevere-app

bedevere-app Bot commented Sep 30, 2024

Copy link
Copy Markdown

GH-124812 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 30, 2024
Yhg1s added a commit that referenced this pull request Oct 1, 2024
@miss-islington @Yhg1s
[3.13] gh-124785: Revert "gh-116510: Fix crash due to shared immortal…
b843974 
… interned strings (gh-124646)" (gh-124807) (#124812)

gh-124785: Revert "gh-116510: Fix crash due to shared immortal interned strings (gh-124646)" (gh-124807)

Revert "gh-116510: Fix crash due to shared immortal interned strings. (gh-124646)"

This reverts commit 98b2ed7.
(cherry picked from commit 7bdfabe)

Co-authored-by: T. Wouters <[email protected]>
Yhg1s added a commit to Yhg1s/cpython that referenced this pull request Oct 1, 2024
@Yhg1s
[3.12] pythongh-124785: Revert "pythongh-116510: Fix crash due to sha…
1f0e989 
…red immortal interned strings (pythongh-124646)" (pythongh-124807)

Revert "pythongh-116510: Fix crash due to shared immortal interned strings. (pythongh-124646)"

This reverts commit 98b2ed7.
(cherry picked from commit 7bdfabe)

Co-authored-by: T. Wouters <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 1, 2024

Copy link
Copy Markdown

GH-124818 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 1, 2024
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Oct 1, 2024
@ericsnowcurrently
Revert "pythongh-124785: Revert "pythongh-116510: Fix crash due to sh…
884f398 
…ared immortal interned strings (pythongh-124646)" (pythongh-124807)"

This reverts commit 7bdfabe.
@Yhg1s
Yhg1s deleted the revert-124646 branch August 13, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@nascheme nascheme

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Yhg1s @nascheme
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.