GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124855: Don't allow the JIT and perf support to be active at the same time by pablogsal · Pull Request #124856 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Don't allow the JIT and perf support to be active at the same time #124855

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from ericsnowcurrently as a code owner October 1, 2024 16:25
@bedevere-app bedevere-app Bot mentioned this pull request Oct 1, 2024
Don't allow the JIT and perf support to be active at the same time #124855
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 1, 2024
@pablogsal
pythongh-124855: Don't allow the JIT and perf support to be active at…
398e38f 
… the same time

Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the nojit branch from f161508 to 398e38f Compare October 1, 2024 16:31
@pablogsal
pablogsal requested a review from brandtbucher October 1, 2024 16:31
Fidget-Spinner
Fidget-Spinner reviewed Oct 1, 2024
View reviewed changes
Comment thread Python/sysmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/sysmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal @Fidget-Spinner
Update Python/sysmodule.c
aeac29c 
Co-authored-by: Ken Jin <[email protected]>
pablogsal
pablogsal commented Oct 1, 2024
View reviewed changes
Comment thread Python/sysmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
rruuaanng
rruuaanng reviewed Oct 2, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2024-10-01-17-31-32.gh-issue-124855.sdsv_H.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@diegorusso

diegorusso commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

Do we need to update the documentation here? https://docs.python.org/3.14/library/sys.html#sys.activate_stack_trampoline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Oct 2, 2024

Copy link
Copy Markdown
Member Author

Good call!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update Python/sysmodule.c
d4b5386 
Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the nojit branch from a39a3fe to d4b5386 Compare October 29, 2024 23:35
@pablogsal
pablogsal enabled auto-merge (squash) October 29, 2024 23:35
@pablogsal pablogsal added the type-bug An unexpected behavior, bug, or error label Oct 29, 2024
Fidget-Spinner
Fidget-Spinner reviewed Oct 30, 2024
View reviewed changes
Comment thread Python/sysmodule.c
#ifdef _Py_JIT
_PyOptimizerObject* optimizer = _Py_GetOptimizer();
if (optimizer != NULL) {
PyErr_SetString(PyExc_ValueError, "Cannot activate the perf trampoline if the JIT is active");

@Fidget-Spinner Fidget-Spinner Oct 30, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're forgetting a Py_DECREF(optimizer) I think.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Fidget-Spinner Fidget-Spinner Oct 30, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablogsal I'm pretty certain there's a refleak here :(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pablogsal pablogsal Oct 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it, sorry I had this on auto-land and I missed your comment :(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

@pablogsal pablogsal Oct 30, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#126163

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal merged commit 2d37c71 into python:main Oct 30, 2024
@pablogsal
pablogsal deleted the nojit branch October 30, 2024 00:12
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 30, 2024
pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 30, 2024
@pablogsal
pythongh-124856: Fix refleak in sys.activate_stack_trampoline
0f70c8f
@pablogsal pablogsal mentioned this pull request Oct 30, 2024
gh-124855: Fix refleak in sys.activate_stack_trampoline #126163
Closed
@mpage mpage mentioned this pull request Oct 31, 2024
test_embed.InitConfigTests.test_initconfig_api fails when cpython is built with --enable-experimental-jit=interpreter #126255
Closed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@pablogsal @picnixz
pythongh-124855: Don't allow the JIT and perf support to be active at…
eb422bc 
… the same time (python#124856)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@pablogsal @ebonnal
pythongh-124855: Don't allow the JIT and perf support to be active at…
50e56b2 
… the same time (python#124856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegorusso diegorusso diegorusso left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@brandtbucher brandtbucher Awaiting requested review from brandtbucher
+1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @diegorusso @Fidget-Spinner @rruuaanng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.