GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] Tee of tee was not producing n independent iterators (gh-123884) by rhettinger · Pull Request #125081 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Oct 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Incorrect optimization in itertools.tee() #123884

📚 Documentation preview 📚: https://cpython-previews--125081.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
pythongh-123884 Tee of tee was not producing n independent iterators (p…
3509123 
…ythongh-124490)
@rhettinger rhettinger added type-bug An unexpected behavior, bug, or error 3.13 only security fixes labels Oct 8, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2024
Incorrect optimization in itertools.tee() #123884
Closed
@rhettinger rhettinger added needs backport to 3.12 only security fixes and removed awaiting core review labels Oct 8, 2024
@rhettinger

rhettinger commented Oct 8, 2024

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Do you know how to fix the ABI stability test failure?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rruuaanng
rruuaanng reviewed Oct 8, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-09-24-22-38-51.gh-issue-123884.iEPTK4.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka requested a review from Yhg1s October 8, 2024 06:17
@serhiy-storchaka

serhiy-storchaka commented Oct 8, 2024

Copy link
Copy Markdown
Member

As a workaround, you perhaps can add a reference to __copy__: (void)&_Py_ID(__copy__).
rhettinger reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rhettinger and others added 2 commits October 8, 2024 02:31
@rhettinger
Keep stable API reference to __copy__
f8fa02f
@rhettinger
Merge branch '3.13' into backport909c6f7
c65671c
serhiy-storchaka
serhiy-storchaka approved these changes Oct 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Oct 8, 2024
@rhettinger
rhettinger merged commit 7bc99dd into python:3.13 Oct 8, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 8, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Sorry, @rhettinger, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7bc99dd49ed4cebe4795cc7914c4231209b2aa4b 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned rhettinger Oct 8, 2024
@rhettinger
rhettinger deleted the backport909c6f7 branch October 8, 2024 19:11
rhettinger added a commit to rhettinger/cpython that referenced this pull request Oct 8, 2024
@rhettinger
[3.13] Tee of tee was not producing n independent iterators (pythongh…
ebbe229 
…-123884) (pythongh-125081)
@tacaswell tacaswell mentioned this pull request Oct 29, 2024
experimental jit causes infinite loops on 3.13 branch #126127
Closed
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s
+1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

3.13 only security fixes type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rhettinger @serhiy-storchaka @rruuaanng @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.