GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-121970: Extract ``availability`` into a new extension by AA-Turner · Pull Request #125082 · python/cpython

Conversation

AA-Turner commented Oct 8, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This gives identical output before-and-after with SOURCE_DATE_EPOCH.

Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--125082.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Extract availability into a new extension

157e6a4

AA-Turner added docs

Documentation in the Doc dir

skip news needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Oct 8, 2024

bedevere-app Bot added the awaiting core review label

Oct 8, 2024

bedevere-app Bot mentioned this pull request

Oct 8, 2024

Improve and reorganise pyspecific #121970

Open

AA-Turner requested review from ezio-melotti and hugovk

October 8, 2024 02:17


          lint

98a0da4

hugovk commented Oct 8, 2024

Copy link

Copy Markdown

Member

Is the point here that it's easier to reason about as a standalone extension, rather than everything being in one big pyspecific.py file?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner commented Oct 8, 2024

Copy link

Copy Markdown

Member Author

Indeed, and also allows for more gradual improvement towards type hints & linting.

We already had a patchy approach with some standalone extensions and a massive pyspecific file, the intended end goal is that each extension is self contained.

pyspecific will probably remain, but will just contain the monkey-patches we apply to Sphinx/Docutils.

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk reviewed

Oct 8, 2024

View reviewed changes

Comment thread

Doc/tools/extensions/availability.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Conditional pluralisation

648f8cb

AA-Turner requested a review from hugovk

October 9, 2024 06:42

hugovk reviewed

Oct 9, 2024

View reviewed changes

hugovk left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick with the (mostly) double quotes from the original (and change the couple of singles into double).

PEP 8 says "In Python, single-quoted strings and double-quoted strings are the same. This PEP does not make a recommendation for this. Pick a rule and stick to it."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reacted with thumbs up emoji

All reactions

👍 1 reaction


          Double quotes

c6a81f0

AA-Turner requested a review from hugovk

October 9, 2024 20:14

hugovk approved these changes

Oct 9, 2024

View reviewed changes

hugovk left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Oct 9, 2024

AA-Turner merged commit cbfd392 into python:main

Oct 9, 2024

AA-Turner deleted the docs/availability branch

October 9, 2024 20:50

bedevere-app Bot removed the awaiting merge label

Oct 9, 2024

miss-islington-app Bot commented Oct 9, 2024

Copy link

Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Oct 9, 2024

Copy link

Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cbfd39247983309a9ef0ae6da6c61cc71665b967 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned AA-Turner

Oct 9, 2024

miss-islington-app Bot commented Oct 9, 2024

Copy link

Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cbfd39247983309a9ef0ae6da6c61cc71665b967 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request

Oct 10, 2024


          [3.13] pythonGH-121970: Extract availability into a new extension (…

3f403f0

…pythonGH-125082)

(cherry picked from commit cbfd392)

Co-authored-by: Adam Turner <[email protected]>

bedevere-app Bot commented Oct 10, 2024

Copy link

Copy Markdown

GH-125237 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Oct 10, 2024

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request

Oct 10, 2024


          [3.12] pythonGH-121970: Extract availability into a new extension (…

b688709

…pythonGH-125082)

(cherry picked from commit cbfd392)

Co-authored-by: Adam Turner <[email protected]>

bedevere-app Bot commented Oct 10, 2024

Copy link

Copy Markdown

GH-125238 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Oct 10, 2024

AA-Turner added a commit that referenced this pull request

Oct 10, 2024


          [3.12] GH-121970: Extract availability into a new extension (GH-1…

caa4924

…25082) (#125238)

(cherry picked from commit cbfd392)

AA-Turner added a commit that referenced this pull request

Oct 10, 2024


          [3.13] GH-121970: Extract availability into a new extension (GH-1…

abb01fd

…25082) (#125237)

(cherry picked from commit cbfd392)

rffontenelle mentioned this pull request

Nov 9, 2024

Availability extension's text translation breaks directive rendering #126609

Closed

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request

Jan 30, 2025


          Revert "pythonGH-121970: Extract availability into a new extension (

3f55056

python#125082)"

This reverts commit cbfd392

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request

Jan 30, 2025


          Revert "[3.12] pythonGH-121970: Extract availability into a new e…

9c0620a

…xtension (pythonGH-125082) (python#125238)"

This reverts commit caa4924

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request

Jan 30, 2025


          Revert "[3.13] pythonGH-121970: Extract availability into a new e…

962bc3f

…xtension (pythonGH-125082) (python#125237)"

This reverts commit abb01fd.

m-aciek added a commit to m-aciek/cpython that referenced this pull request

Jan 30, 2025


          pythongh-126609: docs: revert changes made to the internal structure …

7d8ea9b

…of availability directive

In python#125082.

m-aciek mentioned this pull request

Jan 30, 2025

gh-126609: docs: revert changes made to the internal structure of availability directive #129482

Closed

Reviewers

hugovk

hugovk approved these changes

ezio-melotti

Awaiting requested review from ezio-melotti

Uh oh!

There was an error while loading. Please reload this page.

Assignees

AA-Turner

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AA-Turner commented Oct 8, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugovk commented Oct 8, 2024

Uh oh!

AA-Turner commented Oct 8, 2024

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Oct 9, 2024

Uh oh!

miss-islington-app Bot commented Oct 9, 2024

Uh oh!

miss-islington-app Bot commented Oct 9, 2024

Uh oh!

bedevere-app Bot commented Oct 10, 2024

Uh oh!

bedevere-app Bot commented Oct 10, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AA-Turner commented Oct 8, 2024 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.