GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112433 Docs: Add versionadded value and whatsnew snippet by monkeyman192 · Pull Request #125087 · python/cpython

Conversation

@monkeyman192

@monkeyman192 monkeyman192 commented Oct 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adding documentation changes for this ticket as they were missing.

  • Issue: Add ability to force alignment of ctypes.Structure #112433

📚 Documentation preview 📚: https://cpython-previews--125087.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@monkeyman192
Docs: Add versionadded value and whatsnew snippet (pythongh-112433)
3625730
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2024
Add ability to force alignment of ctypes.Structure #112433
Closed
@AlexWaygood AlexWaygood added needs backport to 3.13 only security fixes topic-ctypes labels Oct 8, 2024
ZeroIntensity
ZeroIntensity approved these changes Oct 8, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @JelleZijlstra, since you requested this on PyDis.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 8, 2024
kumaraditya303
kumaraditya303 reviewed Oct 8, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Update Doc/whatsnew/3.13.rst
a529512
kumaraditya303
kumaraditya303 approved these changes Oct 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 8, 2024
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) October 8, 2024 12:09
@kumaraditya303
kumaraditya303 disabled auto-merge October 8, 2024 12:10
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) October 8, 2024 12:10
kumaraditya303
kumaraditya303 reviewed Oct 8, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Update Doc/whatsnew/3.13.rst
3bbc617
@kumaraditya303
kumaraditya303 merged commit 5967dd8 into python:main Oct 8, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Thanks @monkeyman192 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 8, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Sorry, @monkeyman192 and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5967dd8a4de60a418de84d1d1d9efc063ad12c47 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned kumaraditya303 Oct 8, 2024
@monkeyman192
monkeyman192 deleted the document-gh-112433 branch October 8, 2024 12:57
@bedevere-app

bedevere-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

GH-125113 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 8, 2024
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Oct 8, 2024
@monkeyman192 @kumaraditya303 @JelleZijlstra
[3.13] pythongh-112433 add versionadded for ctypes.Structure._align_ (
f17e5dd 
pythonGH-125087)

(cherry picked from commit 5967dd8)

Co-authored-by: monkeyman192 <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
JelleZijlstra added a commit that referenced this pull request Oct 8, 2024
@JelleZijlstra @monkeyman192 @kumaraditya303
[3.13] gh-112433 add versionadded for ctypes.Structure._align_ (GH-…
089c6d2 
…125087) (#125113)

(cherry picked from commit 5967dd8)

Co-authored-by: monkeyman192 <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull request Oct 9, 2024
@monkeyman192 @kumaraditya303 @efimov-mikhail
pythongh-112433 add versionadded for ctypes.Structure._align_ (pyth…
6b6d27f 
…on#125087)


Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

docs Documentation in the Doc dir skip news topic-ctypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@monkeyman192 @ZeroIntensity @kumaraditya303 @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.