GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90102: Fix pyio return value by cmaloney · Pull Request #125089 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Oct 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Spotted by @ngnpope (https://github.com/python/cpython/pull/124922/files#r1791363776).

isatty returns False to indicate the file is not a TTY. The C implementation of _io does that (Py_RETURN_FALSE) but I got the bool backwards in the _pyio implementaiton.

cc: @vstinner

  • Issue: Avoid calling isatty() for most open() calls #90102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ngnpope reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@cmaloney
pythongh-90102: Fix pyio return value
f68e2b8 
Spotted by @ngnpope.

`isatty` returns False to indicate the file is not a TTY. The C
implementation of _io does that (`Py_RETURN_FALSE`) but I got the
bool backwards in the _pyio implementaiton.
@bedevere-app bedevere-app Bot added the awaiting review label Oct 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2024
Avoid calling isatty() for most open() calls #90102
Closed
@cmaloney cmaloney mentioned this pull request Oct 8, 2024
gh-90102: Remove isatty call during regular open #124922
Merged
@vstinner
vstinner enabled auto-merge (squash) October 8, 2024 11:46
@vstinner
vstinner disabled auto-merge October 8, 2024 11:46
@vstinner
vstinner enabled auto-merge (squash) October 8, 2024 11:47
@vstinner vstinner added the skip news label Oct 8, 2024
@vstinner

vstinner commented Oct 8, 2024

Copy link
Copy Markdown
Member

Oops, hopefully the bug was spotted quickly :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 43ad3b5 into python:main Oct 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 8, 2024
@cmaloney
cmaloney deleted the cmaloney/gh90102-fixup branch October 8, 2024 16:16
efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull request Oct 9, 2024
@cmaloney @efimov-mikhail
pythongh-90102: Fix pyio _isatty_open_only() (python#125089)
148e3fe 
Spotted by @ngnpope.

`isatty` returns False to indicate the file is not a TTY. The C
implementation of _io does that (`Py_RETURN_FALSE`) but I got the
bool backwards in the _pyio implementaiton.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cmaloney @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.