GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-89452: GHA: Set --with-dbmliborder to avoid issues with homebrew's gdbm 1.24 by encukou · Pull Request #125112 · python/cpython

Conversation

@encukou

@encukou encukou commented Oct 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Per #89452 (comment), the issue is fixed in configure for 3.11+, and

For older Python versions, the workaround is to build with:

./configure --with-dbmliborder=gdbm:ndbm

We need this workaround in GitHub Actions, otherwise the tests fail.

See also: gh-105304

  • Issue: test_dbm and test_dbm_ndbm segfaults in M1 Mac with Homebrew gdbm 1.23 #89452

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
[3.10] pythongh-89452: GHA: Set --with-dbmliborder to avoid issues wi…
eac7718 
…th homebrew's gdbm 1.24

Per python#89452 (comment),
the issue is fixed in configure for 3.11+, and

> For older Python versions, the workaround is to build with:
>
>     ./configure --with-dbmliborder=gdbm:ndbm

We need this workaround in GitHub Actions, otherwise the tests fail.
@encukou
encukou requested a review from ezio-melotti as a code owner October 8, 2024 14:11
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2024
test_dbm and test_dbm_ndbm segfaults in M1 Mac with Homebrew gdbm 1.23 #89452
Closed
This was referenced Oct 8, 2024
[3.10] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) #125106
Merged
[3.10] gh-100005: Skip test_script_as_dev_fd() on FreeBSD (GH-100006) #125109
Merged
@encukou encukou added the skip news label Oct 8, 2024
@encukou

encukou commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

@pablogsal @ambv, given #89452 (comment), does this look reasonable to you, as a workaround for a buildsystem/homebrew incompatibility which was fixed better in 3.11+?

If so, I'll also backport to 3.9 and update the Devguide homebrew instructions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

Makes sense to me.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 850189a into python:3.10 Oct 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 8, 2024
@encukou encukou added the needs backport to 3.9 label Oct 8, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Thanks @encukou for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou deleted the mac-dbmliborder-3.10 branch October 8, 2024 14:46
@miss-islington-app

miss-islington-app Bot commented Oct 8, 2024

Copy link
Copy Markdown

Sorry, @encukou and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 850189a64e7f0b920fe48cb12a5da3e648435680 3.9
encukou reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned ambv Oct 8, 2024
@encukou encukou assigned encukou and unassigned ambv Oct 8, 2024
encukou added a commit to encukou/cpython that referenced this pull request Oct 9, 2024
@encukou
[3.9] pythongh-89452: GHA: Set --with-dbmliborder to avoid issues wit…
993f70d 
…h homebrew's gdbm 1.24 (pythonGH-125112)

Per https://github.com/python/cpython/issues/89452GH-issuecomment-1116329316,
the issue is fixed in configure for 3.11+, and

> For older Python versions, the workaround is to build with:
>
>     ./configure --with-dbmliborder=gdbm:ndbm

We need this workaround in GitHub Actions, otherwise the tests fail.
(cherry picked from commit 850189a)
@bedevere-app

bedevere-app Bot commented Oct 9, 2024

Copy link
Copy Markdown

GH-125176 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.9 label Oct 9, 2024
ambv added a commit that referenced this pull request Oct 9, 2024
@encukou @ambv
[3.9] gh-89452: GHA: Set --with-dbmliborder to avoid issues with home…
be988e8 
…brew's gdbm 1.24 (GH-125112) (#125176)

Per https://github.com/python/cpython/issues/89452GH-issuecomment-1116329316,
the issue is fixed in configure for 3.11+, and

> For older Python versions, the workaround is to build with:
>
>     ./configure --with-dbmliborder=gdbm:ndbm

We need this workaround in GitHub Actions, otherwise the tests fail.
(cherry picked from commit 850189a)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.