GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash by mdboom · Pull Request #125218 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Oct 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Compiler crash on MSVC when building with JIT and PGO #125217

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mdboom
pythongh-125217: Turn off optimization are _PyEval_EvalFrameDefault t…
46655f3 
…o avoid MSVC crash
@mdboom mdboom added the skip news label Oct 9, 2024
@mdboom
mdboom requested a review from brandtbucher October 9, 2024 21:24
@mdboom
mdboom requested a review from markshannon as a code owner October 9, 2024 21:24
@bedevere-app bedevere-app Bot mentioned this pull request Oct 9, 2024
Compiler crash on MSVC when building with JIT and PGO #125217
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 9, 2024
@mdboom mdboom changed the title gh-125217: Turn off optimization are _PyEval_EvalFrameDefault to avoid MSVC crash gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash Oct 9, 2024
@mdboom
mdboom marked this pull request as draft October 10, 2024 15:47
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 10, 2024
mdboom added 3 commits October 10, 2024 11:49
@mdboom
Whitespace-only change
4293665
@mdboom
Another whitespace change
946ab27
@mdboom
HACK: Don't require interpreter to pass first
74c6c21
@mdboom

mdboom commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

Closing is this does not resolve the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdboom mdboom closed this Oct 11, 2024
@neonene

neonene commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdboom

mdboom commented Oct 14, 2024

Copy link
Copy Markdown
Contributor Author

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.

Thanks, @neonene. Indeed, that was just a typo on my part and correcting it does work around the compiler crash. Github wouldn't let me re-open this but I have a new PR here: #125477
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@diegorusso diegorusso Awaiting requested review from diegorusso diegorusso will be requested when the pull request is marked ready for review diegorusso is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti will be requested when the pull request is marked ready for review ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk will be requested when the pull request is marked ready for review hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee will be requested when the pull request is marked ready for review JacobCoffee is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mdboom @neonene
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.