GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash by mdboom · Pull Request #125477 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Oct 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Compiler crash on MSVC when building with JIT and PGO #125217

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdboom
mdboom requested review from brandtbucher and markshannon as code owners October 14, 2024 17:36
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
Compiler crash on MSVC when building with JIT and PGO #125217
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 14, 2024
@mdboom mdboom mentioned this pull request Oct 14, 2024
gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash #125218
Closed
@mdboom mdboom added the skip news label Oct 14, 2024
mdboom
mdboom commented Oct 14, 2024
View reviewed changes
Comment thread .github/workflows/jit.yml
./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3
jit:
name: ${{ matrix.target }} (${{ matrix.debug && 'Debug' || 'Release' }})
needs: interpreter

@mdboom mdboom Oct 14, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the requirement on the Tier 2 interpreter pass here, since it seems to be failing consistently on test.test_asyncio.test_taskgroups, and I'm not sure that's relevant to this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@nineteendo nineteendo Oct 14, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #125472.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mdboom mdboom Oct 14, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks. We won't merge these changes, then, but it's useful for now to illustrate that the fix here works.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdboom mdboom added the DO-NOT-MERGE label Oct 14, 2024
@mdboom
pythongh-125217: Turn off optimization around_PyEval_EvalFrameDefault…
8340829 
… to avoid MSVC crash
@mdboom
mdboom force-pushed the disable-interpreter-optimizations-when-jit-enabled branch from bfcfe72 to 8340829 Compare October 15, 2024 14:28
@mdboom mdboom removed the DO-NOT-MERGE label Oct 15, 2024
mdboom
mdboom commented Oct 15, 2024
View reviewed changes
Comment thread Python/jit.c Outdated
#include "pycore_sliceobject.h"
#include "pycore_jit.h"


@mdboom mdboom Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to trigger the JIT CI, but I can remove this commit before merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher
brandtbucher approved these changes Oct 15, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 15, 2024
@mdboom
mdboom force-pushed the disable-interpreter-optimizations-when-jit-enabled branch from a55510c to 8340829 Compare October 16, 2024 12:17
@mdboom
mdboom enabled auto-merge (squash) October 16, 2024 12:22
@mdboom
mdboom merged commit 51410d8 into python:main Oct 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 16, 2024
@mdboom mdboom mentioned this pull request Oct 18, 2024
gh-125498: Update JIT builds to use LLVM 19 and use preserve_none #125499
Merged
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@mdboom @ebonnal
pythongh-125217: Turn off optimization around_PyEval_EvalFrameDefault…
263a8fc 
… to avoid MSVC crash (python#125477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
+1 more reviewer
@nineteendo nineteendo nineteendo left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mdboom @brandtbucher @nineteendo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.