GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-125398: Convert paths in venv activate script when using Git Bash under Windows by julienp · Pull Request #125399 · python/cpython

gh-125398: Convert paths in venv activate script when using Git Bash under Windows #125399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

vsajip merged 4 commits into python:main from julienp:julienp/venv-mingw

Oct 19, 2024

Uh oh!

There was an error while loading. Please reload this page.

Merged

gh-125398: Convert paths in venv activate script when using Git Bash under Windows #125399

Show file tree

Hide file tree

Changes from 2 commits

Commits

Show all changes

4 commits

Select commit Hold shift + click to select a range

61ab573

Convert paths in venv activate script when using Git Bash under Windows

julienp Oct 13, 2024

a81e9cd

Update Misc/NEWS.d/next/Library/2024-10-13-15-04-58.gh-issue-125398.U…

julienp Oct 14, 2024

0879c48

Change to use the envvar role.

vsajip Oct 15, 2024

d47476d

Try to circumvent doc linting error.

vsajip Oct 16, 2024

File filter

Filter by extension .rst (1) No extension (1) All 2 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

4 changes: 2 additions & 2 deletions 4 Lib/venv/scripts/common/activate

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -38,8 +38,8 @@ deactivate nondestructive

		# on Windows, a path can contain colons and backslashes and has to be converted:
		case "$(uname)" in
		CYGWIN\|MSYS)
		# transform D:\path\to\venv to /d/path/to/venv on MSYS
		CYGWIN\|MSYS\|MINGW*)
		# transform D:\path\to\venv to /d/path/to/venv on MSYS and MINGW
		# and to /cygdrive/d/path/to/venv on Cygwin
		VIRTUAL_ENV=$(cygpath "__VENV_DIR__")
		export VIRTUAL_ENV
Expand Down

1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Library/2024-10-13-15-04-58.gh-issue-125398.UW7Ndv.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix the conversion of the ``VIRTUAL_ENV`` path in the activate script in :mod:`venv` when running in Git Bash for Windows.
Comment thread vsajip marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.