GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124958: Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles ... by graingert · Pull Request #125486 · python/cpython

Conversation

@graingert

@graingert graingert commented Oct 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This reverts commit e99650b

  • Issue: CI is failing on current main: test_asyncio.test_taskgroups #125472
  • Issue: refcycles in exceptions raised from asyncio.TaskGroup #124958

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
graingert added 2 commits October 14, 2024 21:58
@graingert
Revert "pythongh-125472: Revert "pythongh-124958: fix asyncio.TaskGro…
050cef9 
…up and _PyFuture refcycles (#12… (python#125476)"

This reverts commit e99650b.
@graingert
fix incompatability with pythongh-124392
79606d6
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
CI is failing on current main: test_asyncio.test_taskgroups #125472
Closed
@graingert graingert changed the title Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles ... gh-125472: Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles ... Oct 14, 2024
@graingert graingert changed the title gh-125472: Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles ... gh-124958: Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles ... Oct 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
refcycles in exceptions raised from asyncio.TaskGroup #124958
Closed
@graingert
graingert marked this pull request as ready for review October 14, 2024 21:14
@graingert
graingert requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners October 14, 2024 21:14
@bedevere-app bedevere-app Bot added the awaiting review label Oct 14, 2024
@gvanrossum
gvanrossum removed their request for review October 14, 2024 21:54
@1st1
1st1 merged commit 0b28ea4 into python:main Oct 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 14, 2024
@1st1

1st1 commented Oct 14, 2024

Copy link
Copy Markdown
Member

This one seems like it would do the trick, let's try.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert
graingert deleted the revert-taskgroup-refcycles-revert branch October 14, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graingert @1st1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.