GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#12… by Eclips4 · Pull Request #125476 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Oct 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

…4959)"

This reverts commit d5dbbf4.

  • Issue: CI is failing on current main: test_asyncio.test_taskgroups #125472

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
Revert "pythongh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (
b8cc4ca 
python#124959)"

This reverts commit d5dbbf4.
@Eclips4
Eclips4 requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners October 14, 2024 17:31
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
CI is failing on current main: test_asyncio.test_taskgroups #125472
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 14, 2024
@Eclips4 Eclips4 added the skip news label Oct 14, 2024
@Eclips4

Eclips4 commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

cc @kumaraditya303
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4

Eclips4 commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

Note for others: We have decided to revert the d5dbbf4 until the root cause has been fixed.
zware reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 added the needs backport to 3.13 only security fixes label Oct 14, 2024
kumaraditya303
kumaraditya303 approved these changes Oct 14, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 14, 2024
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) October 14, 2024 17:42
@kumaraditya303
kumaraditya303 merged commit e99650b into python:main Oct 14, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 14, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 14, 2024
@Eclips4
Eclips4 deleted the revert branch October 14, 2024 17:59
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2024
@Eclips4 @miss-islington
pythongh-125472: Revert "pythongh-124958: fix asyncio.TaskGroup and _…
874bfad 
…PyFuture refcycles (pythonGH-12… (pythonGH-125476)

Revert "pythongh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (pythonGH-124959)"

This reverts commit d5dbbf4.
(cherry picked from commit e99650b)

Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 14, 2024

Copy link
Copy Markdown

GH-125478 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 14, 2024
graingert added a commit to graingert/cpython that referenced this pull request Oct 14, 2024
@graingert
Revert "pythongh-125472: Revert "pythongh-124958: fix asyncio.TaskGro…
050cef9 
…up and _PyFuture refcycles (#12… (python#125476)"

This reverts commit e99650b.
1st1 pushed a commit that referenced this pull request Oct 14, 2024
@graingert
gh-124958: Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGrou…
0b28ea4 
…p and _PyFuture refcycles ... (#125486)

* Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#12… (#125476)"

This reverts commit e99650b.

* fix incompatability with gh-124392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Eclips4 @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.