GeezerVison


          fix test

bdf7781

rruuaanng commented Oct 16, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Please add [Doc] label for PR title. like this


Doc: xxx

fry69 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fry69 changed the title ~~mention actual sqlite3 version attributes in 3.14.rst~~ [Doc] mention actual sqlite3 version attributes in 3.14.rst

fry69 changed the title ~~[Doc] mention actual sqlite3 version attributes in 3.14.rst~~ Doc: mention actual sqlite3 version attributes in 3.14.rst

fry69 commented Oct 16, 2024

Copy link

Copy Markdown

Contributor Author

What is preferred:

[Doc] xxx

Doc: xxx

as a prefix for the title without issue #?

I used the latter for now. Should it be lowercase too like gh-*? I couldn't find guidance for trivial doc changes after a quick search through the contribution guides. Or should such trivial changes be avoided (e.g. to reduce the noise, sorry for that then)?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rruuaanng commented Oct 16, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

In fact, this's just a general behavior, use Doc to mark this PR as documentation.

Sorry, I seem to have missed an s, like this Docs.

fry69 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fry69 changed the title ~~Doc: mention actual sqlite3 version attributes in 3.14.rst~~ Docs: mention actual sqlite3 version attributes in 3.14.rst

StanFromIreland requested a review from hugovk

June 28, 2025 10:51

StanFromIreland reviewed

View reviewed changes

Comment thread

Doc/whatsnew/3.14.rst Outdated


		* Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`.
		* Remove :data:`!version` and :data:`!version_info` from :mod:`sqlite3`;
		use :data:`!sqlite_version` and :data:`!sqlite_version_info` for actual SQLite3

StanFromIreland Jun 28, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be linked since they are not removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

StanFromIreland changed the title ~~Docs: mention actual sqlite3 version attributes in 3.14.rst~~ gh-123299: Provide replacement for removed sqlite3 attributes in What's New 3.14

bedevere-app Bot mentioned this pull request

What's New in Python 3.14 (copyediting) #123299

Closed

hugovk reviewed

View reviewed changes

Comment thread

Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

hugovk added the needs backport to 3.14 bugs and security fixes label


          Link to the existing ones

8f8acb3

hugovk enabled auto-merge (squash)

June 29, 2025 15:27


          Merge branch 'main' into patch-1

3d9ed58

hugovk merged commit 7a403a8 into python:main

github-project-automation Bot moved this from Todo to Done in Docs PRs

miss-islington-app Bot commented Jun 29, 2025

Copy link

Copy Markdown

Thanks @fry69 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting review label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          pythongh-123299: Provide replacement for removed sqlite3 attributes i…

df8bcc3

…n What's New 3.14 (pythonGH-125566)

(cherry picked from commit 7a403a8)

Co-authored-by: fry69 <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>

bedevere-app Bot commented Jun 29, 2025

Copy link

Copy Markdown

GH-136103 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

hugovk commented Jun 29, 2025

Copy link

Copy Markdown

Member

@fry69 Thanks for the PR!

fry69 reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk added a commit that referenced this pull request