GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip checking the compressed bytes (GH-125042) by encukou · Pull Request #125585 · python/cpython

Conversation

@encukou

@encukou encukou commented Oct 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This backports two commits:

  • bpo-46623: Skip two test_zlib tests on s390x #31096 skipped the tests unconditionally
  • gh-125041: test_zlib: For s390x HW acceleration, only skip checking the compressed bytes #125042 skips only the possibly-failing assertion

(cherry picked from commit cc5a225)

  • Issue: Re-enable skipped test_zlib tests on s390x hardware acceleration #125041

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-125041: pythongh-90781: test_zlib: For s390x HW acceleration…
d522856 
…, skip checking the compressed bytes (pythonGH-125042)

This backports two commits:

- pythonGH-31096 skipped the tests unconditionally
- pythonGH-125042 skips only the possibly-failing assertion

(cherry picked from commit cc5a225)
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Oct 16, 2024
This was referenced Oct 16, 2024
Re-enable skipped test_zlib tests on s390x hardware acceleration #125041
Closed
gh-125041: test_zlib: For s390x HW acceleration, only skip checking the compressed bytes #125042
Merged
@encukou

encukou commented Oct 16, 2024

Copy link
Copy Markdown
Member Author

!buildbot s390x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 16, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit d522856 🤖

The command will test the builders whose names match following regular expression: s390x

The builders matched are:

  • s390x RHEL8 PR
  • s390x RHEL8 Refleaks PR
  • s390x RHEL8 LTO PR
  • s390x RHEL9 LTO + PGO PR
  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL9 Refleaks PR
  • s390x RHEL9 LTO PR
  • s390x RHEL9 PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Oct 16, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 16, 2024
@pablogsal
pablogsal merged commit 3c63d80 into python:3.10 Oct 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.