GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125041: test_zlib: For s390x HW acceleration, only skip checking the compressed bytes by encukou · Pull Request #125042 · python/cpython

Conversation

@encukou

@encukou encukou commented Oct 7, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Re-enable skipped test_zlib tests on s390x hardware acceleration #125041

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-125041: test_zlib: For s390x HW acceleration, only skip chec…
126109b 
…king the compressed bytes
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 7, 2024
Re-enable skipped test_zlib tests on s390x hardware acceleration #125041
Closed
rruuaanng
rruuaanng reviewed Oct 8, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2024-10-07-14-13-38.gh-issue-125041.PKLWDf.rst
@@ -0,0 +1,3 @@
Re-enable skipped tests for :mod:`zlib` on the s390x architecture: only skip

@rruuaanng rruuaanng Oct 8, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that NEWS isn't required for unittest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@encukou encukou Oct 8, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's not required.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou

encukou commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

s390x buildbots were removed, so there's no way for me to test this right now :(
@vstinner, do you want to review this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

!buildbot s390x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 126109b 🤖

The command will test the builders whose names match following regular expression: s390x

The builders matched are:

  • s390x RHEL8 PR
  • s390x RHEL8 Refleaks PR
  • s390x RHEL8 LTO PR
  • s390x RHEL9 LTO + PGO PR
  • s390x RHEL8 LTO + PGO PR
  • s390x RHEL9 Refleaks PR
  • s390x RHEL9 LTO PR
  • s390x RHEL9 PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Oct 14, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left minor coding style remarks.

I don't recall exactly the details, I skipped these tests 2 years ago. But from what I read, the change looks correct.

Sadly, I don't recall how to reproduce the issue: how to get access to a s390x machine where the hardware acceleration is enabled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Lib/test/test_zlib.py Outdated
self.assertEqual(zlib.compress(bytearray(data)), x)
if not HW_ACCELERATED:
# With hardware acceleration, the compressed bytes
# might not be identical.

@vstinner vstinner Oct 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: can you put the comment on the if instead? same comment below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_zlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 14, 2024
@encukou

encukou commented Oct 15, 2024

Copy link
Copy Markdown
Member Author

The new builders have HW acceleration -- the tests fail on main :)
vstinner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou commented Oct 15, 2024
View reviewed changes
Comment thread Lib/test/test_zlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou commented Oct 15, 2024
View reviewed changes
Comment thread Lib/test/test_zlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Apply suggestions from code review
213cd08
@encukou

encukou commented Oct 15, 2024

Copy link
Copy Markdown
Member Author

Sorry, not main -- I meant “the existing branch”: 3.10 in particular.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou enabled auto-merge (squash) October 15, 2024 11:06
@encukou
encukou merged commit cc5a225 into python:main Oct 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 15, 2024
@encukou
encukou deleted the zlib-hw-skip branch October 15, 2024 14:25
@encukou encukou added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Oct 15, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 15, 2024

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 15, 2024

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 15, 2024

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 15, 2024

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cc5a225cdc2a5d4e035dd08d59cef39182c10a6c 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned encukou Oct 15, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2024
@encukou @miss-islington
pythongh-125041: test_zlib: For s390x HW acceleration, only skip chec…
2025325 
…king the compressed bytes (pythonGH-125042)

(cherry picked from commit cc5a225)

Co-authored-by: Petr Viktorin <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2024
@encukou @miss-islington
pythongh-125041: test_zlib: For s390x HW acceleration, only skip chec…
4940091 
…king the compressed bytes (pythonGH-125042)

(cherry picked from commit cc5a225)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 15, 2024

Copy link
Copy Markdown

GH-125526 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 15, 2024
@bedevere-app

bedevere-app Bot commented Oct 15, 2024

Copy link
Copy Markdown

GH-125527 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 15, 2024
encukou added a commit that referenced this pull request Oct 16, 2024
@miss-islington @encukou
[3.13] gh-125041: test_zlib: For s390x HW acceleration, only skip che…
e3ae564 
…cking the compressed bytes (GH-125042) (#125527)

(cherry picked from commit cc5a225)

Co-authored-by: Petr Viktorin <[email protected]>
encukou added a commit to encukou/cpython that referenced this pull request Oct 16, 2024
@encukou
pythongh-125041: test_zlib: For s390x HW acceleration, only skip chec…
2819ae2 
…king the compressed bytes (python#125042)

(cherry picked from commit cc5a225)
@bedevere-app

bedevere-app Bot commented Oct 16, 2024

Copy link
Copy Markdown

GH-125577 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 16, 2024
encukou added a commit to encukou/cpython that referenced this pull request Oct 16, 2024
@encukou
pythongh-125041: pythongh-90781: test_zlib: For s390x HW acceleration…
d522856 
…, skip checking the compressed bytes (pythonGH-125042)

This backports two commits:

- pythonGH-31096 skipped the tests unconditionally
- pythonGH-125042 skips only the possibly-failing assertion

(cherry picked from commit cc5a225)
@encukou encukou mentioned this pull request Oct 16, 2024
[3.10] gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip checking the compressed bytes (GH-125042) #125585
Merged
@bedevere-app

bedevere-app Bot commented Oct 16, 2024

Copy link
Copy Markdown

GH-125585 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou added a commit to encukou/cpython that referenced this pull request Oct 16, 2024
@encukou
[3.9] pythongh-125041: pythongh-90781: test_zlib: For s390x HW accele…
21bf2ba 
…ration, skip checking the compressed bytes (pythonGH-125042)

This backports two commits:

- pythonGH-31096 skipped the tests unconditionally
- pythonGH-125042 skips only the possibly-failing assertion

(cherry picked from commit d522856)

Co-authored-by: Petr Viktorin <[email protected]>
@encukou encukou mentioned this pull request Oct 16, 2024
[3.9] gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip checking the compressed bytes (GH-125042) #125587
Merged
@bedevere-app

bedevere-app Bot commented Oct 16, 2024

Copy link
Copy Markdown

GH-125587 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou added a commit that referenced this pull request Oct 16, 2024
@miss-islington @encukou
[3.12] gh-125041: test_zlib: For s390x HW acceleration, only skip che…
cbd50a4 
…cking the compressed bytes (GH-125042) (GH-125526)

(cherry picked from commit cc5a225)

Co-authored-by: Petr Viktorin <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 22, 2024
@encukou
[3.11] gh-125041: test_zlib: For s390x HW acceleration, only skip che…
8630002 
…cking the compressed bytes (GH-125042) (#125577)

gh-125041: test_zlib: For s390x HW acceleration, only skip checking the compressed bytes (#125042)

(cherry picked from commit cc5a225)
pablogsal pushed a commit that referenced this pull request Oct 22, 2024
@encukou
[3.10] gh-125041: gh-90781: test_zlib: For s390x HW acceleration, ski…
3c63d80 
…p checking the compressed bytes (GH-125042) (#125585)

gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip checking the compressed bytes (GH-125042)

This backports two commits:

- GH-31096 skipped the tests unconditionally
- GH-125042 skips only the possibly-failing assertion

(cherry picked from commit cc5a225)
ambv pushed a commit that referenced this pull request Oct 28, 2024
@encukou
[3.9] gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip…
bbe8756 
… checking the compressed bytes (GH-125042) (#125587)

This backports two commits:

- GH-31096 skipped the tests unconditionally
- GH-125042 skips only the possibly-failing assertion

(cherry picked from commit d522856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
+1 more reviewer
@rruuaanng rruuaanng rruuaanng left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @bedevere-bot @vstinner @rruuaanng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.