GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125703: Correctly honour tracemalloc hooks on more PyDECREF specialized paths by pablogsal · Pull Request #125712 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 18, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: _Py_DECREF_SPECIALIZED doesn't respect pymalloc tracking #125703

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from markshannon as a code owner October 18, 2024 19:53
@pablogsal pablogsal added the needs backport to 3.13 only security fixes label Oct 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 18, 2024
_Py_DECREF_SPECIALIZED doesn't respect pymalloc tracking #125703
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 18, 2024
@pablogsal
pablogsal force-pushed the gh-125703-2 branch from a9c4aa3 to 410c2c4 Compare October 18, 2024 19:54
@pablogsal
pablogsal requested a review from brandtbucher as a code owner October 18, 2024 19:54
@pablogsal

pablogsal commented Oct 18, 2024

Copy link
Copy Markdown
Member Author

@markshannon please review this PR. I will not land it until you review it as I don't want to add more fixes like this until we agree on how to fix this problem

If you don't like this approach please tell me what approach you will like.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal mentioned this pull request Oct 18, 2024
gh-125703: Correctly honour tracemalloc hooks on specialized DECREF paths #125704
Merged
@markshannon

markshannon commented Oct 19, 2024

Copy link
Copy Markdown
Member

Since #125704 has already been merged, we may as well merge this for consistency.

I'll make a new issue listing the problems with tracemalloc and the later addition of PyRefTracer_SetTracer causes.
We can discuss solutions there, rather than have them scattered across various issues.

Why the changes to the JIT code? They seem unrelated
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Oct 19, 2024

Copy link
Copy Markdown
Member Author

Why the changes to the JIT code? They seem unrelated

That is unrelated indeed. It got incorrectly mixed, will remove 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Oct 21, 2024
View reviewed changes
Comment thread Tools/jit/_stencils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal force-pushed the gh-125703-2 branch 2 times, most recently from 9f3e194 to 1e098e9 Compare October 21, 2024 11:23
@pablogsal
pythongh-125703: Correctly honour tracemalloc hooks on more PyDECREF …
4c1937d 
…specialized paths
@pablogsal
pablogsal force-pushed the gh-125703-2 branch from 1e098e9 to 4c1937d Compare October 21, 2024 11:23
vstinner
vstinner approved these changes Oct 21, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 21, 2024
@pablogsal pablogsal added the skip news label Oct 21, 2024
@pablogsal

pablogsal commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

I will wait for @markshannon to approve
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

Landing this per #125703 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 3d1df3d into python:main Oct 21, 2024
@pablogsal
pablogsal deleted the gh-125703-2 branch October 21, 2024 14:39
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 21, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added needs backport to 3.13 only security fixes and removed needs backport to 3.13 only security fixes labels Oct 21, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

GH-125791 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 21, 2024
pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 21, 2024
@pablogsal
[3.13] pythongh-125703: Correctly honour tracemalloc hooks on more Py…
c373c86 
…DECREF specialized paths (pythonGH-125712)

(cherry picked from commit 3d1df3d)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Oct 28, 2024
@pablogsal
[3.13] gh-125703: Correctly honour tracemalloc hooks on more PyDECREF…
00b13ec 
… specialized paths (GH-125712) (#125791)

(cherry picked from commit 3d1df3d)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@pablogsal @ebonnal
pythongh-125703: Correctly honour tracemalloc hooks on more PyDECREF …
0db4286 
…specialized paths (python#125712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @markshannon @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.