GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125716: Raise an Exception If _globals_init() Fails In the _interpqueues Module by ericsnowcurrently · Pull Request #125802 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The fix applies to the _interpchannels module as well.

I've also included a drive-by typo fix for _interpqueues.

  • Issue: test_concurrent_futures.test_interpreter_pool failing #125716

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Raise an exception if _globals_init() fails.
7d8b9f9
@ericsnowcurrently ericsnowcurrently added skip news needs backport to 3.13 only security fixes labels Oct 21, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 21, 2024
test_concurrent_futures.test_interpreter_pool failing #125716
Closed
@ericsnowcurrently
Change an incref to a decref.
a3bb4ea
@ericsnowcurrently ericsnowcurrently changed the title gh-125716: Raise an Exception If _globals_init() Fails In The _interpqueues Module gh-125716: Raise an Exception If _globals_init() Fails In the _interpqueues Module Oct 21, 2024
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) October 21, 2024 19:38
@ericsnowcurrently
ericsnowcurrently merged commit 44f841f into python:main Oct 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 21, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2024
@ericsnowcurrently @miss-islington
pythongh-125716: Raise an Exception If _globals_init() Fails In the _…
6a8081c 
…interpqueues Module (pythongh-125802)

The fix applies to the _interpchannels module as well.

I've also included a drive-by typo fix for _interpqueues.
(cherry picked from commit 44f841f)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

GH-125808 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 21, 2024
@ericsnowcurrently
ericsnowcurrently deleted the raise-exception-on-failure branch October 21, 2024 19:39
ericsnowcurrently added a commit that referenced this pull request Oct 21, 2024
@miss-islington @ericsnowcurrently
[3.13] gh-125716: Raise an Exception If _globals_init() Fails In the …
b752764 
…_interpqueues Module (gh-125808)

The fix applies to the _interpchannels module as well.

I've also included a drive-by typo fix for _interpqueues.

(cherry picked from commit 44f841f, AKA gh-125802)

Co-authored-by: Eric Snow <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@ericsnowcurrently @ebonnal
pythongh-125716: Raise an Exception If _globals_init() Fails In the _…
c594724 
…interpqueues Module (pythongh-125802)

The fix applies to the _interpchannels module as well.

I've also included a drive-by typo fix for _interpqueues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.