GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-123930: Correct test of attribute failure to account for iOS by freakboy3742 · Pull Request #125959 · python/cpython

Conversation

freakboy3742 commented Oct 25, 2024

Copy link

Copy Markdown

Contributor

#123929 improved the error message when a Python module shadows a binary module.

However, the test that was added didn't account for the behavior of the iOS import scheme. On iOS, the spec origin and the module's __file__ aren't equivalent, due to the iOS Framework loader. As a result, the test which was looking for the module's __file__ in the exception that is raised failed on the iOS buildbots.

On every other platform, The spec.origin and the module's __file__ are the same, so this PR updates the test to use the spec's origin.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update a test to account for iOS conditions.

41ed908

freakboy3742 added skip issue skip news 3.13

only security fixes

OS-ios 3.14

bugs and security fixes

needs backport to 3.13 only security fixes labels

Oct 25, 2024

freakboy3742 requested a review from hauntsaninja

October 25, 2024 06:28

freakboy3742 requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners

October 25, 2024 06:28

bedevere-app Bot added the awaiting core review label

Oct 25, 2024

freakboy3742 commented Oct 25, 2024

Copy link

Copy Markdown

Contributor Author

!buildbot iOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Oct 25, 2024

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 41ed908 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

iOS ARM64 Simulator PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hauntsaninja approved these changes

Oct 25, 2024

View reviewed changes

hauntsaninja left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Oct 25, 2024

freakboy3742 enabled auto-merge (squash)

October 25, 2024 06:41


          Correct the regex matching the printed error.

8111d82

freakboy3742 commented Oct 25, 2024

Copy link

Copy Markdown

Contributor Author

!buildbot iOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Oct 25, 2024

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 8111d82 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

iOS ARM64 Simulator PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

freakboy3742 merged commit 75401fe into python:main

Oct 25, 2024

miss-islington-app Bot commented Oct 25, 2024

Copy link

Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Oct 25, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 25, 2024


          pythongh-123930: Correct test of attribute failure to account for iOS (…

730b07e

…pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

bedevere-app Bot commented Oct 25, 2024

Copy link

Copy Markdown

GH-125960 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Oct 25, 2024

hauntsaninja pushed a commit that referenced this pull request

Oct 25, 2024


          [3.13] gh-123930: Correct test of attribute failure to account for iOS (

b673581

GH-125959) (#125960)

gh-123930: Correct test of attribute failure to account for iOS (GH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 deleted the ios-binmodule-attr-fail branch

October 25, 2024 07:58

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Dec 13, 2024


          [3.12] pythongh-123930: Correct test of attribute failure to account …

7daa3d4

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Dec 13, 2024


          [3.11] pythongh-123930: Correct test of attribute failure to account …

633545a

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request

Jan 12, 2025


          pythongh-123930: Correct test of attribute failure to account for iOS (…

1bdffc2

…python#125959)

Update a test of importing attributes from binary modules to account for iOS conditions.

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Feb 3, 2026


          [3.11] pythongh-123930: Correct test of attribute failure to account …

10fd22a

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Feb 3, 2026


          [3.12] pythongh-123930: Correct test of attribute failure to account …

1d5b0fe

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Jun 12, 2026


          [3.11] pythongh-123930: Correct test of attribute failure to account …

27d5008

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Jun 12, 2026


          [3.12] pythongh-123930: Correct test of attribute failure to account …

e32dd63

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Oct 2, 2026


          [3.12] pythongh-123930: Correct test of attribute failure to account …

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Oct 2, 2026


          [3.11] pythongh-123930: Correct test of attribute failure to account …

5f5030b

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request

Oct 12, 2026


          [3.12] pythongh-123930: Correct test of attribute failure to account …

a3d7b13

…for iOS (pythonGH-125959) (python#125960)

pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)

Update a test of importing attributes from binary modules to account for iOS conditions.
(cherry picked from commit 75401fe)

Co-authored-by: Russell Keith-Magee <[email protected]>

Reviewers

hauntsaninja

hauntsaninja approved these changes

brettcannon

Awaiting requested review from brettcannon

brettcannon is a code owner

ericsnowcurrently

Awaiting requested review from ericsnowcurrently

ericsnowcurrently is a code owner

ncoghlan

Awaiting requested review from ncoghlan

ncoghlan is a code owner

warsaw

Awaiting requested review from warsaw

warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13

only security fixes

3.14

bugs and security fixes

OS-ios skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.