GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126012: Add `__class_getitem__` to `memoryview` by brianschubert · Pull Request #126013 · python/cpython

Conversation

@brianschubert

@brianschubert brianschubert commented Oct 26, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add __class_getitem__ support to memoryview #126012

📚 Documentation preview 📚: https://cpython-previews--126013.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brianschubert
Add __class_getitem__ to memoryview
2a260d5
@bedevere-app bedevere-app Bot added the awaiting review label Oct 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 26, 2024
Add __class_getitem__ support to memoryview #126012
Closed
picnixz
picnixz reviewed Oct 26, 2024
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks. We should also add some versionchanged for memoryview objects saying that they are now generics.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core and Builtins/2024-10-26-13-32-48.gh-issue-126012.2KalhG.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
brianschubert and others added 3 commits October 26, 2024 14:45
@brianschubert @picnixz
Update Doc/whatsnew/3.14.rst
6f02b08 
Co-authored-by: Bénédikt Tran <[email protected]>
@brianschubert @picnixz
Update Misc/NEWS.d/next/Core and Builtins/2024-10-26-13-32-48.gh-issu…
19c36da 
…e-126012.2KalhG.rst

Co-authored-by: Bénédikt Tran <[email protected]>
@brianschubert
Add versionchanged directive to memoryview docs
b78ab6b
@brianschubert
brianschubert requested a review from picnixz October 26, 2024 18:56
picnixz
picnixz approved these changes Oct 26, 2024
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 26, 2024
ZeroIntensity
ZeroIntensity reviewed Oct 26, 2024
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brianschubert @ZeroIntensity
Update Doc/library/stdtypes.rst
413fa83 
Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity
ZeroIntensity approved these changes Oct 26, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well hop on the approval train :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rruuaanng
rruuaanng approved these changes Oct 27, 2024
View reviewed changes

@rruuaanng rruuaanng left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn
sobolevn approved these changes Oct 27, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brianschubert reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 27, 2024
furkanonder
furkanonder approved these changes Oct 27, 2024
View reviewed changes
@sobolevn
sobolevn merged commit dc76a4a into python:main Oct 27, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 27, 2024
@brianschubert brianschubert mentioned this pull request Oct 27, 2024
Subtype for memoryview required to pass mypy checks but triggersTypeError in Python python/mypy#18053
Closed
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@brianschubert @picnixz @ZeroIntensity
pythongh-126012: Add __class_getitem__ to memoryview (python#126013)
59f49cf 
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@brianschubert @picnixz
@ZeroIntensity @ebonnal
pythongh-126012: Add __class_getitem__ to memoryview (python#126013)
b4d60e9 
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@picnixz picnixz picnixz approved these changes
@furkanonder furkanonder furkanonder approved these changes
@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
+1 more reviewer
@rruuaanng rruuaanng rruuaanng approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@brianschubert @sobolevn @picnixz @furkanonder @ZeroIntensity @rruuaanng
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.