GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-125866: Improve tests for `pathname2url()` and `url2pathname()` (GH-125993) by miss-islington · Pull Request #126145 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Merge URL2PathNameTests and PathName2URLTests test cases (which test
only the Windows-specific implementations from nturl2path) into the main
Pathname_Tests test case for these functions.

Copy/port some test cases for pathlib.Path.as_uri() and from_uri().
(cherry picked from commit 6742f14)

Co-authored-by: Barney Gale [email protected]

  • Issue: Improve file URI ergonomics in urllib.request #125866

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@barneygale @miss-islington
pythonGH-125866: Improve tests for pathname2url() and `url2pathname…
ea8fcb8
…()` (pythonGH-125993)

Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
(cherry picked from commit 6742f14)

Co-authored-by: Barney Gale <[email protected]>
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review skip news labels Oct 29, 2024
This was referenced Oct 29, 2024
GH-125866: Improve tests for pathname2url() and url2pathname() #125993
Merged
Improve file URI ergonomics in urllib.request #125866
Closed
@barneygale
barneygale enabled auto-merge (squash) October 29, 2024 20:47
@barneygale
barneygale merged commit b267b62 into python:3.12 Oct 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 29, 2024
@miss-islington
miss-islington deleted the backport-6742f14-3.12 branch January 2, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.