GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-125866: Improve tests for `pathname2url()` and `url2pathname()` by barneygale · Pull Request #125993 · python/cpython

Conversation

barneygale commented Oct 25, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Merge URL2PathNameTests and PathName2URLTests test cases (which test only the Windows-specific implementations from nturl2path) into the main Pathname_Tests test case for these functions.

Copy/port some test cases that were originally written for pathlib.Path.as_uri() and from_uri().

Issue: Improve file URI ergonomics in urllib.request #125866

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythonGH-125866: Improve tests for pathname2url() and url2pathname()

593b23b

Merge `URL2PathNameTests` `PathName2URLTests` and test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.

barneygale added tests

Tests in the Lib/test dir

skip news labels

Oct 25, 2024

bedevere-app Bot mentioned this pull request

Oct 25, 2024

Improve file URI ergonomics in urllib.request #125866

Closed

bedevere-app Bot added the awaiting core review label

Oct 25, 2024

barneygale added 2 commits

October 25, 2024 20:12


          Fix test

5ebe326


          Merge branch 'main' into pythongh-125866-move-tests

75c2944

barneygale requested a review from zooba

October 25, 2024 20:14


          Improve naming

b155405

rruuaanng approved these changes

Oct 26, 2024

View reviewed changes

rruuaanng left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

barneygale reacted with thumbs up emoji

All reactions

👍 1 reaction

zooba approved these changes

Oct 29, 2024

View reviewed changes

zooba left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I think you may need to merge from main to get the last remaining checks to complete.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

barneygale reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Oct 29, 2024


          Merge branch 'main' into pythongh-125866-move-tests

f455c0d

barneygale commented Oct 29, 2024

Copy link

Copy Markdown

Contributor Author

Thank you both for the reviews, much appreciated!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

barneygale added needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Oct 29, 2024

barneygale enabled auto-merge (squash)

October 29, 2024 20:23

barneygale merged commit 6742f14 into python:main

Oct 29, 2024

bedevere-app Bot removed the awaiting merge label

Oct 29, 2024

miss-islington-app Bot commented Oct 29, 2024

Copy link

Copy Markdown

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 29, 2024


          pythonGH-125866: Improve tests for pathname2url() and `url2pathname…

64c32bd

…()` (pythonGH-125993)

Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
(cherry picked from commit 6742f14)

Co-authored-by: Barney Gale <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 29, 2024


          pythonGH-125866: Improve tests for pathname2url() and `url2pathname…

ea8fcb8

…()` (pythonGH-125993)

Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
(cherry picked from commit 6742f14)

Co-authored-by: Barney Gale <[email protected]>

bedevere-app Bot commented Oct 29, 2024

Copy link

Copy Markdown

GH-126144 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Oct 29, 2024

bedevere-app Bot commented Oct 29, 2024

Copy link

Copy Markdown

GH-126145 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Oct 29, 2024

barneygale added a commit that referenced this pull request

Oct 29, 2024


          [3.12] GH-125866: Improve tests for pathname2url() and `url2pathnam…

b267b62

…e()` (GH-125993) (#126145)

GH-125866: Improve tests for `pathname2url()` and `url2pathname()` (GH-125993)

Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
(cherry picked from commit 6742f14)

Co-authored-by: Barney Gale <[email protected]>

barneygale added a commit that referenced this pull request

Oct 29, 2024


          [3.13] GH-125866: Improve tests for pathname2url() and `url2pathnam…

35108c1

…e()` (GH-125993) (#126144)

GH-125866: Improve tests for `pathname2url()` and `url2pathname()` (GH-125993)

Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.
(cherry picked from commit 6742f14)

Co-authored-by: Barney Gale <[email protected]>

picnixz pushed a commit to picnixz/cpython that referenced this pull request

Dec 8, 2024


          pythonGH-125866: Improve tests for pathname2url() and `url2pathname…

d2f44de

…()` (python#125993)

Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request

Jan 12, 2025


          pythonGH-125866: Improve tests for pathname2url() and `url2pathname…

861925b

…()` (python#125993)

Merge `URL2PathNameTests` and `PathName2URLTests` test cases (which test
only the Windows-specific implementations from `nturl2path`) into the main
`Pathname_Tests` test case for these functions.

Copy/port some test cases for `pathlib.Path.as_uri()` and `from_uri()`.

Reviewers

zooba

zooba approved these changes

+1 more reviewer

rruuaanng

rruuaanng approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

barneygale commented Oct 25, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rruuaanng left a comment

Choose a reason for hiding this comment

Uh oh!

zooba left a comment

Choose a reason for hiding this comment

Uh oh!

barneygale commented Oct 29, 2024

Uh oh!

miss-islington-app Bot commented Oct 29, 2024

Uh oh!

bedevere-app Bot commented Oct 29, 2024

Uh oh!

bedevere-app Bot commented Oct 29, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

barneygale commented Oct 25, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.