GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99108: Cleanup references to inexisting `Modules/_blake2`. by picnixz · Pull Request #126270 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Nov 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since #119316, we removed the internal Modules/_blake2 folder but there were some occurrences left. Somtimes I see this (empty) folder appear in my branch, probably generated by configure or something else. This PR removes the bits related to this (now) inexisting folder.

cc @msprotz @gpshead

  • Issue: Replace built-in hashlib with verified implementations from HACL* #99108

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
Remove references to Modules/_blake2.
e5e2edd
@picnixz
picnixz requested review from a team, corona10, ericsnowcurrently and erlend-aasland as code owners November 1, 2024 09:56
@bedevere-app bedevere-app Bot added the awaiting review label Nov 1, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 1, 2024
Replace built-in hashlib with verified implementations from HACL* #99108
Closed
@picnixz picnixz added the skip news label Nov 1, 2024
@picnixz
Remove Modules/_blake2 entry from CODEOWNERS
c8303fb 
The folder does not exist anymore.
@picnixz
picnixz requested review from ezio-melotti and hugovk as code owners November 1, 2024 15:51
@picnixz
Remove Modules/_blake2 entry from Tools/c-analyzer/TODO
c5c5a10
gpshead
gpshead approved these changes Nov 1, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 1, 2024
@gpshead gpshead added needs backport to 3.13 only security fixes and removed needs backport to 3.13 only security fixes labels Nov 1, 2024
@gpshead
gpshead enabled auto-merge (squash) November 1, 2024 16:18
@gpshead
gpshead merged commit 38a604f into python:main Nov 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 1, 2024
@picnixz
picnixz deleted the chore/remove-blake2-internal-module-references-99108 branch November 1, 2024 16:18
@picnixz

picnixz commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

Thank you for the quick review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@picnixz
pythongh-99108: Cleanup references to inexisting Modules/_blake2. (p…
54773d9 
…ythonGH-126270)

* Remove references to `Modules/_blake2`.

* Remove `Modules/_blake2` entry from CODEOWNERS

The folder does not exist anymore.

* Remove `Modules/_blake2` entry from `Tools/c-analyzer/TODO`
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@picnixz @ebonnal
pythongh-99108: Cleanup references to inexisting Modules/_blake2. (p…
436d742 
…ythonGH-126270)

* Remove references to `Modules/_blake2`.

* Remove `Modules/_blake2` entry from CODEOWNERS

The folder does not exist anymore.

* Remove `Modules/_blake2` entry from `Tools/c-analyzer/TODO`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.