GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-109413: Add more type hints to `libregrtest` (GH-126352) by miss-islington · Pull Request #126388 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit bfc1d25)

Co-authored-by: sobolevn [email protected]

  • Issue: libregrtest: Improve type hints; explore running mypy in CI #109413

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @miss-islington
pythongh-109413: Add more type hints to libregrtest (pythonGH-126352)
0f8ab5c 
(cherry picked from commit bfc1d25)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2024
libregrtest: Improve type hints; explore running mypy in CI #109413
Closed
@bedevere-app bedevere-app Bot added awaiting review skip news labels Nov 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2024
gh-109413: Add more type hints to libregrtest #126352
Merged
sobolevn
sobolevn approved these changes Nov 4, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 4, 2024
@sobolevn
sobolevn enabled auto-merge (squash) November 4, 2024 10:18
@Yhg1s

Yhg1s commented Dec 2, 2024

Copy link
Copy Markdown
Member

This backport seems to have some test failures and merge conflicts that need looking at.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Dec 2, 2024

Copy link
Copy Markdown
Member

Fixing! Thanks for the ping.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 20, 2024

Copy link
Copy Markdown
Member

@sobolevn: There are conflicts again, and many CI tests are failing.

  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/libregrtest/runtests.py", line 109, in RunTests
    def create_worker_runtests(self, **override) -> WorkerRunTests:
                                                    ^^^^^^^^^^^^^^
NameError: name 'WorkerRunTests' is not defined
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added 2 commits January 8, 2025 11:35
@sobolevn
Merge branch '3.13' into backport-bfc1d25-3.13
5dcf0b1
@sobolevn
Update runtests.py
e4cded6
@sobolevn

sobolevn commented Jan 8, 2025

Copy link
Copy Markdown
Member

Done, should be fixed now. Sorry for the long delay.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn merged commit 32012ed into python:3.13 Jan 8, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 8, 2025
@miss-islington
miss-islington deleted the backport-bfc1d25-3.13 branch January 2, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @Yhg1s @sobolevn @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.