Description

AlexWaygood

opened on Sep 14, 2023

Issue body actions

Feature or enhancement

Proposal:

The code in Lib/test/libregrtest already has a smattering of type hints in it, but doesn't currently pass type checking. @vstinner, the primary maintainer of libregrtest, expressed interest to me in seeing whether we could run mypy on libregrtest in CI.

This issue is for tracking progress towards that.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Linked PRs

• gh-109413: libregrtest: Add and improve type annotations #109405
• gh-109413: Fix some trivial mypy nitpicks in libregrtest #109454
• gh-109413: Add a custom script for running mypy on libregrtest #109464
• gh-109413 Improve the mypy config file for libregrtest #109518
• gh-109413: Run mypy on libregrtest in CI #112558
• gh-109413: libregrtest: enable mypy's --strict-optional check on most files #112586
• gh-109413: regrtest: add WorkerRunTests class #112588
• [3.12] gh-109413: regrtest: add WorkerRunTests class (GH-112588) #112593
• [3.11] gh-109413: regrtest: add WorkerRunTests class (GH-112588) #112594
• [3.12] gh-109413: libregrtest: enable mypy's --strict-optional check on most files (#112586) #112602
• [3.11] [3.12] gh-109413: libregrtest: enable mypy's --strict-optional check on most files (GH-112586) (GH-112602) #112603
• [3.12] gh-109413: libregrtest: Backport .py-file changes from #112558 (#112558) #112605
• [3.11] [3.12] gh-109413: libregrtest: Backport .py-file changes from GH-112558 (GH-112605) #112607
• gh-109413: Add more type hints to libregrtest #126352
• [3.13] gh-109413: Add more type hints to libregrtest (GH-126352) #126388
• [3.12] gh-109413: Add more type hints to libregrtest (GH-126352) #126389
• gh-109413: Enable strict_optional for libregrtest/main.py #126394
• [3.13] gh-109413: Enable strict_optional for libregrtest/main.py (GH-126394) #126802
• gh-109413: Enable strict_optional = true for libregrtest/run_workers #126855
• [3.13] gh-109413: Enable strict_optional = true for libregrtest/run_workers (GH-126855) #126967
• gh-109413: Enable mypy's disallow_any_generics setting when checking libregrtest #127033
• [3.13] gh-109413: Enable mypy's disallow_any_generics setting when checking libregrtest (GH-127033) #127034
• gh-109413: Fix libregrtest get_running() #127153
• [3.13] gh-109413: Fix libregrtest get_running() (GH-127153) #127157

Activity

1. AlexWaygood

   added

   type-featureA feature request or enhancementA feature request or enhancement

   testsTests in the Lib/test dirTests in the Lib/test dir

   on Sep 14, 2023
2. AlexWaygood commented on Sep 14, 2023

   

   AlexWaygood

   on Sep 14, 2023

   MemberAuthor

   More actions

   We currently do not have any projects inside the Lib/ directory that are mypy-checked in CI: currently, all the mypy-checked projects we have in CPython live in the Tools/. If we want to actually run mypy on libregrtest in CI, I think it should be discussed on Discourse first, to check if anybody has any objections to this idea.
3. AlexWaygood

   added a commit that references this issue on Sep 14, 2023

   gh-109413: libregrtest: Add and improve type annotations (#109405)

   3b9d10b
4. AlexWaygood

   changed the title [-]libregrtest: Improve type hints; explore running mypy on CI[/-] [+]libregrtest: Improve type hints; explore running mypy in CI[/+] on Sep 14, 2023
5. AlexWaygood

   added 2 commits that reference this issue on Sep 15, 2023

   pythongh-109413: Fix some trivial mypy nitpicks in libregrtest

   95f2e95

   gh-109413: Fix some trivial mypy nitpicks in libregrtest (#109454)

   92ed7e4
6. hauntsaninja

   added a commit that references this issue on Sep 18, 2023

   gh-109413: Improve mypy config for libregrtest (#109518)

   54fbfa8
7. csm10495

   added a commit that references this issue on Sep 28, 2023

   pythongh-109413: Improve mypy config for libregrtest (python#109518)

   ea912a6
8. AlexWaygood

   added 2 commits that reference this issue on Nov 30, 2023

   gh-109413: Run mypy on `libregrtest` in CI (#112558)

   674c288

   pythongh-109413: libregrtest: enable mypy's `--strict-optional` check…

   17b123b
9. vstinner

   added a commit that references this issue on Dec 1, 2023

   pythongh-109413: regrtest: add WorkerRunTests class

   f8c3ac7
10. AlexWaygood

    added a commit that references this issue on Dec 1, 2023

    gh-109413: regrtest: add WorkerRunTests class (#112588)

    f8ff80f
11. miss-islington

    added 2 commits that reference this issue on Dec 1, 2023

    pythongh-109413: regrtest: add WorkerRunTests class (pythonGH-112588)

    8ad4923

    pythongh-109413: regrtest: add WorkerRunTests class (pythonGH-112588)

    597cee5
12. 41 remaining items
13. miss-islington

    added a commit that references this issue on Nov 22, 2024

    pythongh-109413: Fix libregrtest get_running() (pythonGH-127153)

    c638fb3
14. vstinner

    added a commit that references this issue on Nov 22, 2024

    [3.13] gh-109413: Fix libregrtest get_running() (GH-127153) (#127157)

    f0d1a20
15. sobolevn

    added a commit that references this issue on Nov 24, 2024

    [3.13] gh-109413: Enable mypy's `disallow_any_generics` setting when …

    24b8630
16. picnixz

    added 2 commits that reference this issue on Dec 8, 2024

    pythongh-109413: Add more type hints to `libregrtest` (python#126352)

    93f9c6f

    pythongh-109413: Enable `strict_optional` for `libregrtest/main.py` (p…

    4157281
17. sobolevn

    added a commit that references this issue on Jan 8, 2025

    [3.13] gh-109413: Add more type hints to `libregrtest` (GH-126352) (#…

    32012ed
18. ebonnal

    added 5 commits that reference this issue on Jan 12, 2025

    pythongh-109413: Add more type hints to `libregrtest` (python#126352)

    affbdb2

    pythongh-109413: Enable `strict_optional` for `libregrtest/main.py` (p…

    440b7e9

    pythongh-109413: Enable `strict_optional = true` for `libregrtest/run…

    d8ce082

    pythongh-109413: Enable mypy's `disallow_any_generics` setting when c…

    ef2ea26

    pythongh-109413: Fix libregrtest get_running() (python#127153)

    e371b3f
19. hugovk commented on Jul 5, 2026

    

    hugovk

    on Jul 5, 2026

    Member

    More actions

    More to do here, or can we close this issue?
20. vstinner commented on Jul 6, 2026

    

    vstinner

    on Jul 6, 2026

    Member

    More actions

    IMO this issue can be closed. libregrtest is now well covered by mypy.
21. sobolevn

    closed this as completedon Jul 6, 2026
22. AlexWaygood commented on Jul 6, 2026

    

    AlexWaygood

    on Jul 6, 2026

    MemberAuthor

    More actions

    There are still lots of config options that would ideally be made stricter on this package, but I don't have the energy to work on that right now, and there's little point leaving this open if nobody else does either, so I also support it being closed :-)

    Reacted by Victor Stinner

Issue actions