GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126390: Support for preserving order of options and nonoption arguments in gnu_getopt() by serhiy-storchaka · Pull Request #126393 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 4, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Preserving order of options and nonoption arguments in gnu_getopt() #126390

📚 Documentation preview 📚: https://cpython-previews--126393.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2024
Preserving order of options and nonoption arguments in gnu_getopt() #126390
Closed
gpshead
gpshead reviewed Nov 6, 2024
View reviewed changes
Comment thread Lib/test/test_getopt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Nov 6, 2024

Copy link
Copy Markdown
Member Author

This PR should be merged after #126375 (where that typo was already fixed.).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

This PR should be merged after #126375 (where that typo was already fixed.).

So let's mark it as a draft to make that more obvious.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka marked this pull request as draft November 6, 2024 22:05
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 6, 2024
serhiy-storchaka and others added 2 commits November 11, 2024 18:32
@serhiy-storchaka
pythongh-126390: Support for preserving order of options and nonoptio…
0659bd2 
…n arguments in gnu_getopt()
@gpshead @serhiy-storchaka
minor docstring typo fix.
aff48a2
@serhiy-storchaka
serhiy-storchaka force-pushed the getopt-return-in-order branch from 1b6a8e2 to aff48a2 Compare November 11, 2024 16:33
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review November 11, 2024 16:39
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 11, 2024
@serhiy-storchaka

serhiy-storchaka commented Nov 11, 2024

Copy link
Copy Markdown
Member Author

Now this PR only contains the changes for #126390.
erlend-aasland and gpshead reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka commented Nov 11, 2024
View reviewed changes
Comment thread Lib/getopt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead added the type-feature A feature request or enhancement label Nov 13, 2024
@gpshead gpshead mentioned this pull request Nov 13, 2024
gh-126374: Add support of options with optional arguments in the getopt module #126375
Merged
gpshead
gpshead approved these changes Nov 13, 2024
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice feature!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 13, 2024
@serhiy-storchaka

serhiy-storchaka commented Nov 13, 2024

Copy link
Copy Markdown
Member Author

Thank you for your review @gpshead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit 35010b8 into python:main Nov 13, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 13, 2024
@serhiy-storchaka
serhiy-storchaka deleted the getopt-return-in-order branch November 13, 2024 20:50
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 13, 2024
Support options with optional arguments #126374
Closed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@serhiy-storchaka @picnixz
pythongh-126390: Support for preserving order of options and nonoptio…
6f3cc66 
…n arguments in gnu_getopt() (pythonGH-126393)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@serhiy-storchaka @ebonnal
pythongh-126390: Support for preserving order of options and nonoptio…
31a0795 
…n arguments in gnu_getopt() (pythonGH-126393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @erlend-aasland @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.