GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126451: Register contextvars.Context to collections.abc.Mapping by tungol · Pull Request #126452 · python/cpython

gh-126451: Register contextvars.Context to collections.abc.Mapping #126452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 10 commits into python:main from tungol:contextvars-abc
Nov 6, 2024

Uh oh!

There was an error while loading. Please reload this page.
Merged

gh-126451: Register contextvars.Context to collections.abc.Mapping #126452

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
74b3631
Register contextvars.Context to collections.abc.Mapping
tungol Nov 5, 2024
9c4e3f5
test that all the methods are present
tungol Nov 5, 2024
3a1f8b2
test for callability, sort methods alphabetically in the test
tungol Nov 5, 2024
8c68b5b
minor spacing
tungol Nov 5, 2024
aa0da03
Update Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.X…
tungol Nov 5, 2024
72d6726
import _collections_abc instead of collections.abc
tungol Nov 5, 2024
b0c38e8
use subtests
tungol Nov 5, 2024
96e2280
add issubclass check
tungol Nov 6, 2024
5cdad6a
Update Lib/test/test_context.py
tungol Nov 6, 2024
0e0a5e6
fix duplicate line
tungol Nov 6, 2024
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

4 changes: 4 additions & 0 deletions 4 Lib/contextvars.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import collections.abc
from _contextvars import Context, ContextVar, Token, copy_context


__all__ = ('Context', 'ContextVar', 'Token', 'copy_context')


collections.abc.Mapping.register(Context)
Comment thread
tungol marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.
12 changes: 12 additions & 0 deletions 12 Lib/test/test_context.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import collections.abc
import concurrent.futures
import contextvars
import functools
Expand Down Expand Up @@ -350,6 +351,17 @@ def ctx2_fun():

ctx1.run(ctx1_fun)

def test_context_isinstance(self):
ctx = contextvars.Context()
self.assertIsInstance(ctx, collections.abc.Mapping)
Comment thread
tungol marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.

mapping_methods = (
'__contains__', '__eq__', '__getitem__', '__iter__', '__len__',
'__ne__', 'get', 'items', 'keys', 'values',
)
for name in mapping_methods:
Comment thread
kumaraditya303 marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.
self.assertTrue(callable(getattr(ctx, name)))
Comment thread
tungol marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.

@isolated_context
@threading_helper.requires_working_threading()
def test_context_threads_1(self):
Expand Down
2 changes: 2 additions & 0 deletions 2 Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.XJMtqz.rst
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Register the :class:`contextvars.Context` type to
:class:`collections.abc.Mapping`.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.