GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-76785: Minor Cleanup of "Cross-interpreter" Code by ericsnowcurrently · Pull Request #126457 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 5, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The primary objective here is to allow some later changes to be cleaner. Mostly this involves renaming things and moving a few things around.

  • *CrossInterpreterData* -> *XIData*
  • crossinterpdatafunc -> xidatafunc
  • split out pycore_crossinterp_data_registry.h
  • add _PyXIData_lookup_t
  • Issue: [subinterpreters] PEP 554 implementation: add interpreters module #76785

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 8 commits November 5, 2024 12:12
@ericsnowcurrently
_PyCrossInterpreterData -> _PyXIData_t
f513a3c
@ericsnowcurrently
crossinterpdatafunc -> xidatafunc
873973a
@ericsnowcurrently
CrossInterpreterData -> XIData
9057584
@ericsnowcurrently
Adjust declaration groups.
759d399
@ericsnowcurrently
Move an include to the right file.
ccf3edc
@ericsnowcurrently
Use the local typedefs.
81eacbf
@ericsnowcurrently
Split out pycore_crossinterp_data_registry.h.
8c2586d
@ericsnowcurrently
Wrap _PyXIData_registry_t with a new _PyXIData_lookup_t.
5eb7adb
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 5, 2024
@ericsnowcurrently
ericsnowcurrently requested review from a team and erlend-aasland as code owners November 5, 2024 21:32
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 5, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 5, 2024
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
@ericsnowcurrently
Fix the c-analyzer.
ab27394
@ZeroIntensity

ZeroIntensity commented Nov 6, 2024

Copy link
Copy Markdown
Member

It looks like most of this is just find and replace renaming, but I can give it a once-over tomorrow if you want a second set of eyes.
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity
ZeroIntensity approved these changes Nov 6, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's not much to comment about here--it's all renaming as far as I can tell, and I don't think nitpicking formatting or something like that would be a good use of time :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ericsnowcurrently
ericsnowcurrently merged commit 9357fdc into python:main Nov 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 7, 2024
@ericsnowcurrently
ericsnowcurrently deleted the crossinterp-cleanup branch November 7, 2024 16:32
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@ericsnowcurrently @picnixz
pythongh-76785: Minor Cleanup of "Cross-interpreter" Code (pythongh-1…
64bd446 
…26457)

The primary objective here is to allow some later changes to be cleaner. Mostly this involves renaming things and moving a few things around.

* CrossInterpreterData -> XIData
* crossinterpdatafunc -> xidatafunc
* split out pycore_crossinterp_data_registry.h
* add _PyXIData_lookup_t
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@ericsnowcurrently @ebonnal
pythongh-76785: Minor Cleanup of "Cross-interpreter" Code (pythongh-1…
63bb816 
…26457)

The primary objective here is to allow some later changes to be cleaner. Mostly this involves renaming things and moving a few things around.

* CrossInterpreterData -> XIData
* crossinterpdatafunc -> xidatafunc
* split out pycore_crossinterp_data_registry.h
* add _PyXIData_lookup_t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.