GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126455: Disallow _ssl.SSLSocket instantiation by vstinner · Pull Request #126481 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Prevent creation of incomplete/invalid _ssl.SSLSocket objects when created directly.

  • Issue: Calling many methods on _ssl._SSLSocket() segfaults #126455

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-126455: Disallow _ssl.SSLSocket instantiation
c70daa7 
Prevent creation of incomplete/invalid _ssl.SSLSocket objects when
created directly.
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 6, 2024
@vstinner vstinner added skip news and removed awaiting core review labels Nov 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2024
Calling many methods on _ssl._SSLSocket() segfaults #126455
Closed
@vstinner vstinner added the awaiting core review label Nov 6, 2024
kumaraditya303
kumaraditya303 approved these changes Nov 6, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 6, 2024
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Nov 6, 2024
asvetlov
asvetlov approved these changes Nov 6, 2024
View reviewed changes
@vstinner
vstinner merged commit b1c4ffc into python:main Nov 6, 2024
@miss-islington-app

miss-islington-app Bot commented Nov 6, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the ssl_sock branch November 6, 2024 10:59
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2024
@vstinner @miss-islington
pythongh-126455: Disallow _ssl.SSLSocket instantiation (pythonGH-126481)
c5c4bd1 
Prevent creation of incomplete/invalid _ssl.SSLSocket objects when
created directly.
(cherry picked from commit b1c4ffc)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 6, 2024

Copy link
Copy Markdown

GH-126486 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2024
@vstinner @miss-islington
pythongh-126455: Disallow _ssl.SSLSocket instantiation (pythonGH-126481)
a873496 
Prevent creation of incomplete/invalid _ssl.SSLSocket objects when
created directly.
(cherry picked from commit b1c4ffc)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 6, 2024

Copy link
Copy Markdown

GH-126487 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 6, 2024
vstinner added a commit that referenced this pull request Nov 6, 2024
@miss-islington @vstinner
[3.12] gh-126455: Disallow _ssl.SSLSocket instantiation (GH-126481) (#…
e6fd40b 
…126487)

gh-126455: Disallow _ssl.SSLSocket instantiation (GH-126481)

Prevent creation of incomplete/invalid _ssl.SSLSocket objects when
created directly.
(cherry picked from commit b1c4ffc)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Nov 6, 2024
@miss-islington @vstinner
[3.13] gh-126455: Disallow _ssl.SSLSocket instantiation (GH-126481) (#…
6a084b9 
…126486)

gh-126455: Disallow _ssl.SSLSocket instantiation (GH-126481)

Prevent creation of incomplete/invalid _ssl.SSLSocket objects when
created directly.
(cherry picked from commit b1c4ffc)

Co-authored-by: Victor Stinner <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@vstinner @picnixz
pythongh-126455: Disallow _ssl.SSLSocket instantiation (python#126481)
8abfb36 
Prevent creation of incomplete/invalid _ssl.SSLSocket objects when
created directly.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@vstinner @ebonnal
pythongh-126455: Disallow _ssl.SSLSocket instantiation (python#126481)
ecf4ced 
Prevent creation of incomplete/invalid _ssl.SSLSocket objects when
created directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @asvetlov @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.