GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Postpone `module.__loader__` deprecation to Python 3.16 by hugovk · Pull Request #126482 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Nov 6, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Related to #122255:

There was a flaw in implementation of the warnings so we should first fix the warnings in 3.14 and prolong the deprecation period until 3.16.

See also #123011.

📚 Documentation preview 📚: https://cpython-previews--126482.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Postpone module.__loader__ deprecation to Python 3.16
7bd7111
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Nov 6, 2024
@hugovk
hugovk requested a review from willingc as a code owner November 6, 2024 10:26
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 6, 2024
@hugovk hugovk added the skip issue label Nov 6, 2024
rpshbhandari
rpshbhandari reviewed Nov 8, 2024
View reviewed changes

@rpshbhandari rpshbhandari left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on catching this one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hauntsaninja
hauntsaninja approved these changes Nov 10, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 10, 2024
@hauntsaninja
hauntsaninja merged commit 450db61 into python:main Nov 10, 2024
@miss-islington-app

miss-islington-app Bot commented Nov 10, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 10, 2024
@miss-islington-app

miss-islington-app Bot commented Nov 10, 2024

Copy link
Copy Markdown

Sorry, @hugovk and @hauntsaninja, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 450db61a78989c5a1f1106be01e071798c783cf9 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned hauntsaninja Nov 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2024
@hugovk @miss-islington
Postpone module.__loader__ deprecation to Python 3.16 (pythonGH-126482
2d9e9ae 
)

(cherry picked from commit 450db61)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 10, 2024

Copy link
Copy Markdown

GH-126637 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 10, 2024
hauntsaninja pushed a commit to hauntsaninja/cpython that referenced this pull request Nov 10, 2024
@hugovk @hauntsaninja
Postpone module.__loader__ deprecation to Python 3.16 (python#126482)
ed74ca5 
(cherry picked from commit 450db61)
@bedevere-app

bedevere-app Bot commented Nov 10, 2024

Copy link
Copy Markdown

GH-126638 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 10, 2024
@bedevere-app

bedevere-app Bot commented Nov 10, 2024

Copy link
Copy Markdown

GH-126638 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja pushed a commit that referenced this pull request Nov 10, 2024
@miss-islington @hugovk
[3.12] Postpone module.__loader__ deprecation to Python 3.16 (GH-12…
61e6f09 
…6482) (#126637)

Postpone `module.__loader__` deprecation to Python 3.16 (GH-126482)
(cherry picked from commit 450db61)

Co-authored-by: Hugo van Kemenade <[email protected]>
hauntsaninja added a commit that referenced this pull request Nov 10, 2024
@hauntsaninja @hugovk
[3.13] Postpone module.__loader__ deprecation to Python 3.16 (GH-12…
fa3ee75 
…6482) (#126638)

Postpone `module.__loader__` deprecation to Python 3.16 (#126482)

(cherry picked from commit 450db61)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
hugovk deleted the docs-postpone-module-loader-deprecation branch November 10, 2024 09:44
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@hugovk @picnixz
Postpone module.__loader__ deprecation to Python 3.16 (python#126482)
1fc5262
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk @ebonnal
Postpone module.__loader__ deprecation to Python 3.16 (python#126482)
f8852a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@willingc willingc Awaiting requested review from willingc willingc is a code owner
+1 more reviewer
@rpshbhandari rpshbhandari rpshbhandari left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hauntsaninja hauntsaninja

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @hauntsaninja @rpshbhandari
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.